[reSIProcate] Fwd: [reSIProcate-commit] resiprocate 7077 nash:inside resip/stack/Transaction::process method contains complex

Scott Godin slgodin at icescape.com
Mon Apr 16 16:29:04 CDT 2007 

I agree as well.

 

Scott

 

From: resiprocate-devel-bounces at list.resiprocate.org
[mailto:resiprocate-devel-bounces at list.resiprocate.org] On Behalf Of
Jason Fischl
Sent: Monday, April 16, 2007 5:22 PM
To: Byron Campen
Cc: resiprocate-devel
Subject: Re: [reSIProcate] Fwd: [reSIProcate-commit] resiprocate 7077
nash:inside resip/stack/Transaction::process method contains complex

 

I'm also not very keen on this change without doing lots of thinking
first. Can I suggest that we back this out for now. 

Thanks
Jason



On 4/16/07, Byron Campen <bcampen at estacado.net> wrote:

          Yikes! Can we put this in a branch somewhere so we have time
to digest it? I get the distinct impression that this large of a change
is going to cause a lot of headaches for a lot of people. Mind you, I
can see why this sort of change might be desirable, but this seems a tad
aggressive. I would also like to have a chance to look into the
performance impact that this work has. I don't want to get lynched when
it comes time to push 1.2 out...

 

Best regards,

Byron Campen

 

Begin forwarded message:





From: svn at resiprocate.org

Date: April 16, 2007 5:07:24 AM CDT

To: resiprocate-commit at list.resiprocate.org

Subject: [reSIProcate-commit] resiprocate 7077 nash: inside
resip/stack/Transaction::process method contains complex

 

Project

resiprocate

New Revision

7077 <http://svn.resiprocate.org/viewsvn/resiprocate?view=rev&rev=7077> 

Committer

nash (Nash Tsai)

Date

2007-04-16 05:07:24 -0500 (Mon, 16 Apr 2007)


Log

 inside resip/stack/Transaction::process method contains complex 


 logics and message ptr can be easily leaked if it's not maintained by 

 original coder, therefore I changed to SharedPtr usage and made a bunch


 of code changed to make it compile.

 

 Also another place worth mention as TimeLimitFifo::add method could 


 result memory leak usage, and it's fixed on the way for above changes.

 

 The tests under rutil/stack/dum has passed as well.

 

 resip/stack/Security add to allow disable server authentication check




 

 

 

 

Modified:


*	main/repro/Dispatcher.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/Dispatcher.cx
x?r1=7076&r2=7077&diff_format=l> 
*	main/repro/Dispatcher.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/Dispatcher.hx
x?r1=7076&r2=7077&diff_format=l> 
*	main/repro/Proxy.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/Proxy.cxx?r1=
7076&r2=7077&diff_format=l> 
*	main/repro/RequestContext.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/RequestContex
t.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/repro/RequestContext.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/RequestContex
t.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/repro/ResponseContext.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/ResponseConte
xt.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/repro/UserStore.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/UserStore.cxx
?r1=7076&r2=7077&diff_format=l> 
*	main/repro/WorkerThread.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/WorkerThread.
cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ClientInviteSession.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientInv
iteSession.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ClientPagerMessage.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPag
erMessage.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ClientPublication.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPub
lication.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ClientRegistration.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientReg
istration.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ClientSubscription.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientSub
scription.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/DialogUsageManager.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DialogUsa
geManager.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/DialogUsageManager.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DialogUsa
geManager.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/DumFeature.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeatur
e.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/DumFeature.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeatur
e.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/DumFeatureChain.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeatur
eChain.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/DumFeatureChain.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeatur
eChain.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/DumThread.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumThread
.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/EncryptionManager.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/Encryptio
nManager.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/EncryptionManager.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/Encryptio
nManager.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/EventDispatcher.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/EventDisp
atcher.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/IdentityHandler.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/IdentityH
andler.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/IdentityHandler.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/IdentityH
andler.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/InviteSession.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSes
sion.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/InviteSession.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSes
sion.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/Postable.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/Postable.
hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ServerAuthManager.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerAut
hManager.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ServerAuthManager.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerAut
hManager.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ServerInviteSession.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerInv
iteSession.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/ServerPagerMessage.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerPag
erMessage.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/TargetCommand.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/TargetCom
mand.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/TargetCommand.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/TargetCom
mand.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/test/RegEventClient.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/RegE
ventClient.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/test/UserAgent.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/User
Agent.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/test/UserAgent.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/User
Agent.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/test/testSMIMEInvite.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/test
SMIMEInvite.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/dum/test/treg.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/treg
.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/DnsInterface.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/DnsInte
rface.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/DnsResult.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/DnsResu
lt.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/DnsResult.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/DnsResu
lt.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/SdpContents.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SdpCont
ents.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/SdpContents.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SdpCont
ents.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/Security.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Securit
y.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/Security.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Securit
y.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/SipMessage.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SipMess
age.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/SipStack.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SipStac
k.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/SipStack.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SipStac
k.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/StatelessHandler.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Statele
ssHandler.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TimerQueue.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TimerQu
eue.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TimerQueue.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TimerQu
eue.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TlsConnection.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TlsConn
ection.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TransactionController.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Transac
tionController.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TransactionState.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Transac
tionState.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TransactionState.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Transac
tionState.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TransactionUser.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Transac
tionUser.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TransactionUser.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Transac
tionUser.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TuIM.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TuIM.cx
x?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TuSelector.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TuSelec
tor.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/TuSelector.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TuSelec
tor.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/UAS.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/UA
S.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/test503Generator.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
st503Generator.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testAppTimer.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stAppTimer.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testClient.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stClient.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testLockStep.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stLockStep.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testRSP-2.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stRSP-2.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testResponses.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stResponses.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testServer.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stServer.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testSipStack1.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stSipStack1.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testStack.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stStack.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/resip/stack/test/testTransactionFSM.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/te
stTransactionFSM.cxx?r1=7076&r2=7077&diff_format=l> 
*	main/rutil/Fifo.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/Fifo.hxx?r1=7
076&r2=7077&diff_format=l> 
*	main/rutil/TimeLimitFifo.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/TimeLimitFifo
.hxx?r1=7076&r2=7077&diff_format=l> 
*	main/rutil/Timer.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/Timer.cxx?r1=
7076&r2=7077&diff_format=l> 
*	main/rutil/Timer.hxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/Timer.hxx?r1=
7076&r2=7077&diff_format=l> 
*	main/rutil/test/testFifo.cxx
<http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/test/testFifo
.cxx?r1=7076&r2=7077&diff_format=l> 

_______________________________________________

resiprocate-commit mailing list

resiprocate-commit at list.resiprocate.org

https://list.resiprocate.org/mailman/listinfo/resiprocate-commit

 


_______________________________________________
resiprocate-devel mailing list
resiprocate-devel at list.resiprocate.org
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel 



 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20070416/a25199a6/attachment.htm>

More information about the resiprocate-devel mailing list