[reSIProcate] Fwd: [reSIProcate-commit] resiprocate 7077 nash:inside resip/stack/Transaction::process method contains complex

[Robert Sparks]

Nash - we're going to revert this change. Please make a branch for  
them and let us know where to look for it.

Thanks,

RjS

On Apr 16, 2007, at 11:29 PM, Scott Godin wrote:

> I agree as well.
>
>
>
> Scott
>
>
>
> From: resiprocate-devel-bounces at list.resiprocate.org  
> [mailto:resiprocate-devel-bounces at list.resiprocate.org] On Behalf  
> Of Jason Fischl
> Sent: Monday, April 16, 2007 5:22 PM
> To: Byron Campen
> Cc: resiprocate-devel
> Subject: Re: [reSIProcate] Fwd: [reSIProcate-commit] resiprocate  
> 7077 nash:inside resip/stack/Transaction::process method contains  
> complex
>
>
>
> I'm also not very keen on this change without doing lots of  
> thinking first. Can I suggest that we back this out for now.
>
> Thanks
> Jason
>
>
> On 4/16/07, Byron Campen <bcampen at estacado.net> wrote:
>
>           Yikes! Can we put this in a branch somewhere so we have  
> time to digest it? I get the distinct impression that this large of  
> a change is going to cause a lot of headaches for a lot of people.  
> Mind you, I can see why this sort of change might be desirable, but  
> this seems a tad aggressive. I would also like to have a chance to  
> look into the performance impact that this work has. I don't want  
> to get lynched when it comes time to push 1.2 out...
>
>
>
> Best regards,
>
> Byron Campen
>
>
>
> Begin forwarded message:
>
>
>
>
> From: svn at resiprocate.org
>
> Date: April 16, 2007 5:07:24 AM CDT
>
> To: resiprocate-commit at list.resiprocate.org
>
> Subject: [reSIProcate-commit] resiprocate 7077 nash: inside resip/ 
> stack/Transaction::process method contains complex
>
>
>
> Project
>
> resiprocate
>
> New Revision
>
> 7077
>
> Committer
>
> nash (Nash Tsai)
>
> Date
>
> 2007-04-16 05:07:24 -0500 (Mon, 16 Apr 2007)
>
> Log
>
>  inside resip/stack/Transaction::process method contains complex
>
>  logics and message ptr can be easily leaked if it's not maintained by
>
>  original coder, therefore I changed to SharedPtr usage and made a  
> bunch
>
>  of code changed to make it compile.
>
>
>
>  Also another place worth mention as TimeLimitFifo::add method could
>
>  result memory leak usage, and it's fixed on the way for above  
> changes.
>
>
>
>  The tests under rutil/stack/dum has passed as well.
>
>
>
>  resip/stack/Security add to allow disable server authentication check
>
>
>
>
>
>
>
>
>
>
> Modified:
>
> main/repro/Dispatcher.cxx
> main/repro/Dispatcher.hxx
> main/repro/Proxy.cxx
> main/repro/RequestContext.cxx
> main/repro/RequestContext.hxx
> main/repro/ResponseContext.cxx
> main/repro/UserStore.cxx
> main/repro/WorkerThread.cxx
> main/resip/dum/ClientInviteSession.cxx
> main/resip/dum/ClientPagerMessage.cxx
> main/resip/dum/ClientPublication.cxx
> main/resip/dum/ClientRegistration.cxx
> main/resip/dum/ClientSubscription.cxx
> main/resip/dum/DialogUsageManager.cxx
> main/resip/dum/DialogUsageManager.hxx
> main/resip/dum/DumFeature.cxx
> main/resip/dum/DumFeature.hxx
> main/resip/dum/DumFeatureChain.cxx
> main/resip/dum/DumFeatureChain.hxx
> main/resip/dum/DumThread.cxx
> main/resip/dum/EncryptionManager.cxx
> main/resip/dum/EncryptionManager.hxx
> main/resip/dum/EventDispatcher.hxx
> main/resip/dum/IdentityHandler.cxx
> main/resip/dum/IdentityHandler.hxx
> main/resip/dum/InviteSession.cxx
> main/resip/dum/InviteSession.hxx
> main/resip/dum/Postable.hxx
> main/resip/dum/ServerAuthManager.cxx
> main/resip/dum/ServerAuthManager.hxx
> main/resip/dum/ServerInviteSession.cxx
> main/resip/dum/ServerPagerMessage.cxx
> main/resip/dum/TargetCommand.cxx
> main/resip/dum/TargetCommand.hxx
> main/resip/dum/test/RegEventClient.cxx
> main/resip/dum/test/UserAgent.cxx
> main/resip/dum/test/UserAgent.hxx
> main/resip/dum/test/testSMIMEInvite.cxx
> main/resip/dum/test/treg.cxx
> main/resip/stack/DnsInterface.cxx
> main/resip/stack/DnsResult.cxx
> main/resip/stack/DnsResult.hxx
> main/resip/stack/SdpContents.cxx
> main/resip/stack/SdpContents.hxx
> main/resip/stack/Security.cxx
> main/resip/stack/Security.hxx
> main/resip/stack/SipMessage.cxx
> main/resip/stack/SipStack.cxx
> main/resip/stack/SipStack.hxx
> main/resip/stack/StatelessHandler.cxx
> main/resip/stack/TimerQueue.cxx
> main/resip/stack/TimerQueue.hxx
> main/resip/stack/TlsConnection.cxx
> main/resip/stack/TransactionController.cxx
> main/resip/stack/TransactionState.cxx
> main/resip/stack/TransactionState.hxx
> main/resip/stack/TransactionUser.cxx
> main/resip/stack/TransactionUser.hxx
> main/resip/stack/TuIM.cxx
> main/resip/stack/TuSelector.cxx
> main/resip/stack/TuSelector.hxx
> main/resip/stack/test/UAS.cxx
> main/resip/stack/test/test503Generator.cxx
> main/resip/stack/test/testAppTimer.cxx
> main/resip/stack/test/testClient.cxx
> main/resip/stack/test/testLockStep.cxx
> main/resip/stack/test/testRSP-2.cxx
> main/resip/stack/test/testResponses.cxx
> main/resip/stack/test/testServer.cxx
> main/resip/stack/test/testSipStack1.cxx
> main/resip/stack/test/testStack.cxx
> main/resip/stack/test/testTransactionFSM.cxx
> main/rutil/Fifo.hxx
> main/rutil/TimeLimitFifo.hxx
> main/rutil/Timer.cxx
> main/rutil/Timer.hxx
> main/rutil/test/testFifo.cxx
> _______________________________________________
>
> resiprocate-commit mailing list
>
> resiprocate-commit at list.resiprocate.org
>
> https://list.resiprocate.org/mailman/listinfo/resiprocate-commit
>
>
>
>
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel at list.resiprocate.org
> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>
>
>
>
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel at list.resiprocate.org
> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20070417/d6a1f15f/attachment.htm>