[reSIProcate] Fwd: [reSIProcate-commit] resiprocate 7077 nash: inside resip/stack/Transaction::process method contains complex

Jason Fischl jason at counterpath.com
Mon Apr 16 16:22:02 CDT 2007 

I'm also not very keen on this change without doing lots of thinking first.
Can I suggest that we back this out for now.

Thanks
Jason


On 4/16/07, Byron Campen <bcampen at estacado.net> wrote:
>
> Yikes! Can we put this in a branch somewhere so we have time to digest it?
> I get the distinct impression that this large of a change is going to cause
> a lot of headaches for a lot of people. Mind you, I can see why this sort of
> change might be desirable, but this seems a tad aggressive. I would also
> like to have a chance to look into the performance impact that this work
> has. I don't want to get lynched when it comes time to push 1.2 out...
> Best regards,
> Byron Campen
>
> Begin forwarded message:
>
> *From: *svn at resiprocate.org
> *Date: *April 16, 2007 5:07:24 AM CDT
> *To: *resiprocate-commit at list.resiprocate.org
> *Subject: **[reSIProcate-commit] resiprocate 7077 nash: inside
> resip/stack/Transaction::process method contains complex*
>
>  ProjectresiprocateNew Revision7077<http://svn.resiprocate.org/viewsvn/resiprocate?view=rev&rev=7077>
> Committernash (Nash Tsai)Date2007-04-16 05:07:24 -0500 (Mon, 16 Apr 2007)
> Log
>
>  inside resip/stack/Transaction::process method contains complex
>  logics and message ptr can be easily leaked if it's not maintained by
>  original coder, therefore I changed to SharedPtr usage and made a bunch
>  of code changed to make it compile.
>
>  Also another place worth mention as TimeLimitFifo::add method could
>  result memory leak usage, and it's fixed on the way for above changes.
>
>  The tests under rutil/stack/dum has passed as well.
>
>  resip/stack/Security add to allow disable server authentication check
>
>
>
>
>
> Modified:
>
>    - main/repro/Dispatcher.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/Dispatcher.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/repro/Dispatcher.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/Dispatcher.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/repro/Proxy.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/Proxy.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/repro/RequestContext.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/RequestContext.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/repro/RequestContext.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/RequestContext.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/repro/ResponseContext.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/ResponseContext.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/repro/UserStore.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/UserStore.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/repro/WorkerThread.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/repro/WorkerThread.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ClientInviteSession.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientInviteSession.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ClientPagerMessage.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPagerMessage.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ClientPublication.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPublication.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ClientRegistration.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientRegistration.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ClientSubscription.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientSubscription.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/DialogUsageManager.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DialogUsageManager.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/DialogUsageManager.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DialogUsageManager.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/DumFeature.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeature.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/DumFeature.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeature.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/DumFeatureChain.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeatureChain.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/DumFeatureChain.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumFeatureChain.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/DumThread.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumThread.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/EncryptionManager.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/EncryptionManager.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/EncryptionManager.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/EncryptionManager.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/EventDispatcher.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/EventDispatcher.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/IdentityHandler.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/IdentityHandler.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/IdentityHandler.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/IdentityHandler.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/InviteSession.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSession.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/InviteSession.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSession.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/Postable.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/Postable.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ServerAuthManager.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerAuthManager.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ServerAuthManager.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerAuthManager.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ServerInviteSession.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerInviteSession.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/ServerPagerMessage.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerPagerMessage.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/TargetCommand.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/TargetCommand.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/TargetCommand.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/TargetCommand.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/test/RegEventClient.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/RegEventClient.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/test/UserAgent.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/UserAgent.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/test/UserAgent.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/UserAgent.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/test/testSMIMEInvite.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/testSMIMEInvite.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/dum/test/treg.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/test/treg.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/DnsInterface.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/DnsInterface.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/DnsResult.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/DnsResult.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/DnsResult.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/DnsResult.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/SdpContents.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SdpContents.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/SdpContents.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SdpContents.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/Security.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Security.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/Security.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/Security.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/SipMessage.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SipMessage.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/SipStack.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SipStack.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/SipStack.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/SipStack.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/StatelessHandler.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/StatelessHandler.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TimerQueue.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TimerQueue.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TimerQueue.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TimerQueue.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TlsConnection.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TlsConnection.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TransactionController.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TransactionController.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TransactionState.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TransactionState.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TransactionState.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TransactionState.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TransactionUser.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TransactionUser.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TransactionUser.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TransactionUser.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TuIM.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TuIM.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TuSelector.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TuSelector.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/TuSelector.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/TuSelector.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/UAS.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/UAS.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/test503Generator.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/test503Generator.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testAppTimer.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testAppTimer.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testClient.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testClient.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testLockStep.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testLockStep.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testRSP-2.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testRSP-2.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testResponses.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testResponses.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testServer.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testServer.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testSipStack1.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testSipStack1.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testStack.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testStack.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/resip/stack/test/testTransactionFSM.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/stack/test/testTransactionFSM.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/rutil/Fifo.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/Fifo.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/rutil/TimeLimitFifo.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/TimeLimitFifo.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/rutil/Timer.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/Timer.cxx?r1=7076&r2=7077&diff_format=l>
>    - main/rutil/Timer.hxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/Timer.hxx?r1=7076&r2=7077&diff_format=l>
>    - main/rutil/test/testFifo.cxx
>    <http://svn.resiprocate.org/viewsvn/resiprocate/main/rutil/test/testFifo.cxx?r1=7076&r2=7077&diff_format=l>
>
> _______________________________________________
> resiprocate-commit mailing list
> resiprocate-commit at list.resiprocate.org
> https://list.resiprocate.org/mailman/listinfo/resiprocate-commit
>
>
>
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel at list.resiprocate.org
> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20070416/a8d65789/attachment.htm>

More information about the resiprocate-devel mailing list