Re: [reSIProcate] RFC 3455 headers and parameters
Hi Daniel,
I created the separate pull request for project file.
It can be consulted at the following link:
https://github.com/resiprocate/resiprocate/pull/7
Best regards,
Dario.
-----Original Message-----
From: Daniel Pocock [mailto:daniel@xxxxxxxxxx]
Sent: giovedì 18 settembre 2014 20.17
To: Dario Bozzali; resiprocate-devel@xxxxxxxxxxxxxxx
Cc: 'slgodin@xxxxxxxxx'
Subject: Re: [reSIProcate] RFC 3455 headers and parameters
On 18/09/14 14:50, Dario Bozzali wrote:
> Hi all,
> I created pull request for these changes in new GitHub repository.
> Daniel told me that GitHub notifications to list is not active yet, so please
> visit pull request at the following link:
> https://github.com/resiprocate/resiprocate/pull/6
>
> Daniel noticed that User-to-User header could create backward
> incompatibility, but if you agree we could integrate changes that John posted
> for RFC 3455.
Just to clarify - I'm not opposed to this change, I think it is good to have.
Avaya phone systems support that header and people are using it.
I have actually tried injecting it into SIP messages from a PyRoute plugin in
repro and it works quite easily. It is just a bit disruptive for the existing
stable release.
> Note that I also patched resiprocate_8_0.vcproj file, because
> WssConnection.cxx and WssTransport.cxx must be excluded by no-SSL builds.
>
Can you please put that change on a separate branch?
This is what is known as making an "atomic" commit. I should have explained
that in the wiki too.
It means we can "git cherry-pick" the change to the 1.9.x branch without also
getting the rest of the UUI stuff.
Using the Git command line, you could do:
git branch exclude-wss master
git checkout exclude-wss
git add resiprocate_8_0.vcproj
git commit -m 'build: Visual Studio: exclude WSS for non-SSL build'
git push -u origin exclude-wss
and then go into Github and send a pull request for that change alone.
Regards,
Daniel