Re: [reSIProcate] RFC 3455 headers and parameters
Hi all,
I created pull request for these changes in new GitHub repository.
Daniel told me that GitHub notifications to list is not active yet, so please
visit pull request at the following link:
https://github.com/resiprocate/resiprocate/pull/6
Daniel noticed that User-to-User header could create backward incompatibility,
but if you agree we could integrate changes that John posted for RFC 3455.
Note that I also patched resiprocate_8_0.vcproj file, because WssConnection.cxx
and WssTransport.cxx must be excluded by no-SSL builds.
Best regards,
Dario.
-----Original Message-----
From: resiprocate-devel [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On
Behalf Of Dario Bozzali
Sent: mercoledì 17 settembre 2014 13.11
To: 'Daniel Pocock'; 'slgodin@xxxxxxxxx'
Cc: resiprocate-devel@xxxxxxxxxxxxxxx
Subject: Re: [reSIProcate] RFC 3455 headers and parameters
Hi all,
I checked testParserCategories using unchanged mainline sources and I obtained
errors again.
I found that errors are produced by function testParseAndWrite() for NameAddr
and Via (see attached file testParserCategories_output.txt), and not by changes.
In the new patch file I inserted also the changes for testParserCategories.cxx
and testGperfHash.cxx to check new headers and parameters and it seems that
they work.
I didn't follow testParserCategories.cxx code using a debugger. Does anyone
know testParseAndWrite() function and can he explain errors reported in the log?
Best regards,
Dario.
-----Original Message-----
From: resiprocate-devel [mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On
Behalf Of Daniel Pocock
Sent: martedì 16 settembre 2014 21.32
To: resiprocate-devel@xxxxxxxxxxxxxxx
Subject: Re: [reSIProcate] RFC 3455 headers and parameters
On 16/09/14 20:27, Scott Godin wrote:
> I just tried applying the patch and running the
> stack/test/testParserCategories test suite. I got failures. My
> cycles are limited right now - can you try out this test suite and see
> if you can pinpoint the issue?
This would be an interesting contribution to submit as a Github pull request.
Travis-CI will automatically try to build the project with the proposed patch
and run the test cases and tell us if it is good to merge.
_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel