< Previous by Date Date Index Next by Date >
  Thread Index Next in Thread >

[reSIProcate] RFC 3455 headers and parameters



I changed the following files:

M       Token.cxx
M       ParameterTypes.cxx
M       Headers.hxx
M       SipMessage.cxx
M       HeaderTypes.hxx
M       ParameterTypeEnums.hxx
M       HeaderHash.cxx
M       ParameterHash.cxx
M       Token.hxx
M       Headers.cxx
M       HeaderHash.gperf
M       ParameterHash.gperf
M       ParameterTypes.hxx
M       SipMessage.hxx

All I did was add the following header definitions, where appropriate:

defineHeader(PAccessNetworkInfo, "P-Access-Network-Info", Token, "RFC 3455");
defineHeader(PChargingVector, "P-Charging-Vector", Token, "RFC 3455");
defineHeader(PChargingFunctionAddresses, "P-Charging-Function-Addresses", Token, "RFC 3455"); defineMultiHeader(PVisitedNetworkID, "P-Visited-Network-ID", Token, "RFC 3455");

And the following parameters:

defineParam(description, "description", QuotedDataParameter, "RFC 3840"); defineParam(utranCellId3gpp, "utran-cell-id-3gpp", DataParameter, "RFC 3455"); // P-Access-Network-Info defineParam(cgi3gpp, "cgi-3gpp", DataParameter, "RFC 3455"); // P-Access-Network-Info defineParam(ccf, "ccf", DataParameter, "RFC 3455"); // P-Charging-Function-Addresses defineParam(ecf, "ecf", DataParameter, "RFC 3455"); // P-Charging-Function-Addresses defineParam(icidValue, "icid-value", DataParameter, "RFC 3455"); // P-Charging-Vector defineParam(icidGeneratedAt, "icid-generated-at", DataParameter, "RFC 3455"); // P-Charging-Vector defineParam(origIoi, "orig-ioi", DataParameter, "RFC 3455"); // P-Charging-Vector defineParam(termIoi, "term-ioi", DataParameter, "RFC 3455"); // P-Charging-Vector


I figured it would be less confusing to just describe the changes than to include diff files for all the files involved, but I can do that upon request. I think it would be a good idea to incorporate this change into the next resiprocate release, and I can't see a downside. I'm not completely sure that Token is the right object type to use for all of them, but it worked for me.

-John Gregg