Re: [reSIProcate] [resip/stack][patch 1/2] Code cleanup for ConnectionBase.cxx

[Zhi An Ng <ngzhian@xxxxxxxxx>]

Hi Daniel,

Sorry for the trouble. I forked resiprocate/resiprocate on GitHub and
have submitted a pull request. I have also attached two patches from
`git format-patch`, please use which ever is more convenient.

Thank you for your tips!

Best,
Zhi An

On Mon, May 13, 2013 at 8:29 PM, Daniel Pocock <daniel@xxxxxxxxxxxxx> wrote:
> On 10/05/13 18:48, Zhi An Ng wrote:
>> Hi all,
>>
>> This patch removes an entire portion of wsProcessHandshake() that
>> deals with an deprecated protocol. [1]
>> There is also a bit of refactoring. Scanning the message header is its
>> own function now. Making the handshake response is also its own
>> function, which handles instances when a header can not be found.
>
> Hi Anzai,
>
> Is this the final version of the diff?  It appears to be not quite
> complete and has a couple of errors in it.  Please send the final
> version that should be commited to SVN.  I think you must have modified
> at least one other file, but you only sent the diff for ConnectionBase.cxx
>
> Also, can you please send as an attachment?  That helps avoid formatting
> problems caused by email software, and it allows easy retrieval of the
> patch from the mailing list web archive.
>
> Regards,
>
> Daniel
>
>



-- 
Best,
Zhi An

Attachment: 0001-Removed-deprecated-protocol-checking.-Minor-refactor.patch
Description: Binary data

Attachment: 0002-Rename-class.-Move-test-methods-out-of-main-method.patch
Description: Binary data