< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] [resip/stack][patch 2/2] Code cleanup for test/testConnectionBase.cxx


On 10/05/13 18:48, Zhi An Ng wrote:
> Hi all,
>
> This patch renames the the fake transport class (FakeTransport ->
> FakeTCPTransport), and added a new FakeWSTransport class. This will
> facilitate adding test cases.
> The original test is moved into its own function, testTCPConnection().
> This will allow more tests, e.g. testWsProcessHandshake(), to be
> added, and makes the main function cleaner and easier to understand.
>
This is a really useful contribution

However, the patch fails to apply, I think it is a formatting error -
can you please send as an attachment?

If you are a git user, you can make a convenient local copy of the
repository from our github mirror, and use the git format-patch command
to extract patches suitable for attaching to email, or you can submit
pull requests through github:
https://github.com/resiprocate/resiprocate