Re: [reSIProcate] [resip/stack][patch 1/2] Code cleanup for ConnectionBase.cxx
On 10/05/13 18:48, Zhi An Ng wrote:
> Hi all,
>
> This patch removes an entire portion of wsProcessHandshake() that
> deals with an deprecated protocol. [1]
> There is also a bit of refactoring. Scanning the message header is its
> own function now. Making the handshake response is also its own
> function, which handles instances when a header can not be found.
Hi Anzai,
Is this the final version of the diff? It appears to be not quite
complete and has a couple of errors in it. Please send the final
version that should be commited to SVN. I think you must have modified
at least one other file, but you only sent the diff for ConnectionBase.cxx
Also, can you please send as an attachment? That helps avoid formatting
problems caused by email software, and it allows easy retrieval of the
patch from the mailing list web archive.
Regards,
Daniel