[reSIProcate] [resip/stack][patch] Fixes for previous patch (titled: Code cleanup for ConnectionBase.cxx)

Zhi An Ng ngzhian at gmail.com
Sun May 19 07:11:49 CDT 2013


Hi all,

The patch I submitted had some problems, sorry about that. Here are 2
commits to fix the issues brought up by Daniel (thanks!).

First commit has to do with a missing return value in:
`ConnectionBase::scanMsgHeader(int bytesRead)`

Second patch is regarding the returned value of
`makeWsHandshakeResponse()`, it now returns a std::auto_ptr<Data> to
reduce memory usage. The check for the return value of this function
is also fixed changed to
`if (wsResponsePtr.get())`

These changes are also reflected in the pull request on GitHub.

Thank you.

--
Best,
Zhi An
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Fix-for-function-not-returning-correctly.patch
Type: application/octet-stream
Size: 634 bytes
Desc: not available
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20130519/1b32fb5f/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Changed-return-value-of-makeWsHandshakeResponse.patch
Type: application/octet-stream
Size: 2983 bytes
Desc: not available
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20130519/1b32fb5f/attachment-0001.obj>


More information about the resiprocate-devel mailing list