[reSIProcate] iteration corruption ending an in-dialog subscription

[Justin Matthews]

I think there is a problem ending client and server subscriptions from
Dialog::end.  Both the Dialog::end function and the destructor of the
ServerSubscription or ClientSubscription classes reference the same
collection.  There is similar code in Dialog.cxx to avoid this situation.
Attached is the patch.  If there are no objections I will apply it.

 

Dialog::end()->m(Server|Client)Subscriptions

 

(Server|Client)Subscription::~
(Server|Client)Subscription()->mDialog.m(Server|Client)Subscriptions->remove
(this).

 

Thanks,

 

-justin

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20080414/07d68d72/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: indialogsubscribeend.patch
Type: application/octet-stream
Size: 1121 bytes
Desc: not available
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20080414/07d68d72/attachment.obj>