[reSIProcate] [PATCH] reSUBSCRIBE will fail if the server fails to send NOTIFY

[Adam Roach]

Aron Rosenberg wrote:
>
> If you are using subscriptions there is a chance that the stack will 
> not issue a reSUBSCRIBE. The main way this can happen is if the 
> presence server does NOT issue a NOTIFY upon resiprocate sending out a 
> reSUBSCRIBE and no NOTIFY’s are issued during the time of the 
> subscription.
>
> This patch adds the reSUBSCRIBE timer upon receiving the 200 OK to the 
> SUBSCRIBE request instead of only adding the timer upon receipt of a 
> NOTIFY.
>

Without this NOTIFY, the only proper thing to do is tear down the 
subscription. Lacking this NOTIFY, we have to assume the far end has 
gone away.

> The OpenSER presence server currently exhibits this broken behavior.
>

It would appear that you're submitting a patch to the wrong project, 
then. ;-)

> There doesn’t appear to be any harm to adding the timer on the 200 OK 
> instead of waiting for the NOTIFY
>

As has been pointed out by others, this creates problems when the 
SUBSCRIBE forks.

/a