[reSIProcate] sdp bug + why mCurrentLocalSdp, mProposedLocalSdp, mCurrentRemoteSdp and mProposedRemoteSdp

[Scott Godin]

Good find.  I committed a fix.

 

Thanks!

 

Proposed is an offer that hasn't been accepted yet.  When answered - the
proposed sdp is copied to the Current sdp.

 

  _____  

From: resiprocate-devel-bounces at list.sipfoundry.org
[mailto:resiprocate-devel-bounces at list.sipfoundry.org] On Behalf Of Micky
Kaufmann
Sent: Sunday, September 25, 2005 6:29 AM
To: resiprocate-devel at list.sipfoundry.org
Subject: [reSIProcate] sdp bug + why mCurrentLocalSdp,
mProposedLocalSdp,mCurrentRemoteSdp and mProposedRemoteSdp

 

Hi,

 

First of all I'm pretty sure there's a bug in
ServerInviteSession::sendProvisional :

         .

         .

         .

         if (mCurrentLocalSdp.get()) // early media

         {

            setSdp(m1xx, mProposedLocalSdp.get());

         }

         .

         .

         .

 

The variable checked in the if clause isn't the one sent to setSdp!!!

 

I think mCurrentLocalSdp is the correct variable to send to setSdp.

However, I don't completely understand the idea behind 'Current' and
'Proposed' in mCurrentLocalSdp, mProposedLocalSdp, mCurrentRemoteSdp and
mProposedRemoteSdp variables.

Is 'Proposed' always an offer and 'Current' always an answer? (In the case
of offer/answer)

 

 

Micky Kaufmann 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20050926/0e2cd759/attachment.htm>