Re: [reSIProcate-users] TLS and SRTP and recon bug report

[Karlsson <boost.regex@xxxxxxxxx>]

Sorry, please ignore my question 1, I think it's my mistake.

On Fri, Feb 27, 2009 at 3:51 PM, Karlsson <boost.regex@xxxxxxxxx> wrote:

Hi all, I was added the TLS and SRTP support into my project as recon project, but it's not working.


1:

I have checked recon source code, maybe I found a bug:

bool
MediaStream::createOutboundSRTPSession(SrtpCryptoSuite cryptoSuite, const char* key, unsigned int keyLen)
{
   if(keyLen != SRTP_MASTER_KEY_LEN)
   {
      ErrLog(<< "Unable to create outbound SRTP session, invalid keyLen=" << keyLen);
     
.....
}

bool
MediaStream::createInboundSRTPSession(SrtpCryptoSuite cryptoSuite, const char* key, unsigned int keyLen)
{
   if(keyLen != SRTP_MASTER_KEY_LEN)
   {
      ErrLog(<< "Unable to create inbound SRTP session, invalid keyLen=" << keyLen);
      return false;
   }

  ......
}

But when make SRTP call with Bria pro, the keyLen parameter for inbound and outbound all are 40, so these two functions never succeeded, does this a bug ?
I think there should be:

   if(keyLen < SRTP_MASTER_KEY_LEN)
   {
      ErrLog(<< "Unable to create inbound SRTP session, invalid keyLen=" << keyLen);
      return false;
   }

I have tried this code it's working, but when I sent the SRTP packet to bria pro, the bria pro log file says: "Error while extracting RTP packet for incoming stream. Msg: 'Error while decrypting SRTP packet; authentication failure'." | sua::CSRTPSource::Decrypt


2: I'm runing repro with on 192.168.1.198:5061 with TLS, I using my UA and bria pro to test the TLS call, after the bria anwered 200 ok, my ua sent an ACK,
but the bria never received my ACK, so the bria was terminated call after 30 seconds. Why ? 


Thanks