Re: [reSIProcate] ares_mkquery.c doesn't compile after last commit
Hello Gregor,
Sorry for late answer, but I'm quite busy in these days. I pushed the commit in
ares.h some minutes ago. Hope that's ok (Travis build is ok).
Unfortunately I pushed a first commit with the wrong user.name setting. I don't
know if this is a problem, but now in history the same commit appears twice
with two different author names.
@Daniel: since you are a git guru, I trust you: is it possible to fix the
history or doesn't matter? Sorry for the mess.
Best regards,
Dario.
-----Original Message-----
From: Gregor Jasny [mailto:gjasny@xxxxxxxxxxxxxx]
Sent: mercoledì 9 agosto 2017 17.12
To: Dario Bozzali <Dario.Bozzali@xxxxxxxxxxx>; resiprocate-devel@xxxxxxxxxxxxxxx
Subject: Re: [reSIProcate] ares_mkquery.c doesn't compile after last commit
Hello,
On 08.08.17 12:40, Dario Bozzali wrote:
> Hi all,
>
> I aligned my reSIProcate repository to origin master and I noticed
> that ares doesn't build anymore under Windows.
>
> Issue has been introduced in commit
> 920273631b699bcaf9ea3c2c448eb9af5a924b70(26/06/2017) due to missing
> MAXCDNAME definition under Windows (I tested ares_14_0.vcxproj using
> Visual Studio 2017 Enterprise).
Sorry about that. We should think about adding appveyor tests for windows.
> I prefer the change in ares.h. Other comments / suggestions?
I'm also in favor of adding it to ares.h. Since you already did 95% of the
work, could you please file a pull request and assign it to me?
Thanks,
Gregor