Re: [reSIProcate] [resiprocate/resiprocate] added some executables, .cxx, .h and Makefile to gitignore (#42)

[Thomas Thorne <notifications@xxxxxxxxxx>]

The build failure seems a little strange to me based on the pull request subject.

libtool: link: g++ -I .. -Wformat -Werror=format-security -fpermissive -Wall -Wno-deprecated -o .libs/reTurnServer reTurnServer.o AsyncSocketBase.o AsyncUdpSocketBase.o AsyncTcpSocketBase.o AsyncTlsSocketBase.o ChannelManager.o ConnectionManager.o DataBuffer.o RemotePeer.o RequestHandler.o ReTurnConfig.o ReTurnSubsystem.o StunAuth.o StunMessage.o StunTuple.o TcpConnection.o TcpServer.o TlsConnection.o TlsServer.o TurnAllocation.o TurnAllocationKey.o TurnAllocationManager.o TurnManager.o TurnPermission.o UdpRelayServer.o UdpServer.o UserAuthData.o  ../rutil/.libs/librutil.so -lssl -lcrypto -lpthread -lcares
reTurnServer.o: In function `reTurn::ReTurnServerProcess::main(int, char**)':
reTurnServer.cxx:(.text+0x4ee): undefined reference to `reTurn::TlsServer::TlsServer(asio::io_service&, reTurn::RequestHandler&, asio::ip::address const&, unsigned short)'
reTurnServer.cxx:(.text+0x5f3): undefined reference to `reTurn::TlsServer::TlsServer(asio::io_service&, reTurn::RequestHandler&, asio::ip::address const&, unsigned short)'
reTurnServer.cxx:(.text+0x932): undefined reference to `reTurn::TlsServer::start()'
reTurnServer.cxx:(.text+0x99b): undefined reference to `reTurn::TlsServer::start()'
collect2: ld returned 1 exit status
make[3]: *** [reTurnServer] Error 1
make[3]: Leaving directory `/home/travis/build/resiprocate/resiprocate/reTurn'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/travis/build/resiprocate/resiprocate/reTurn'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/resiprocate/resiprocate'
make: *** [all] Error 2
The command "./build/travis/build" exited with 2.

I guess it is possible that a header is now missing or not correctly included by make and that is what has lost the reTurn::TlsServer::start() reference?

Although while looking at this the stated objective of ''added some executables, .cxx, .h and Makefile to gitignore'' seems a little strange to me as well. Do we not want source, header and make files to be included by git? I agree that you do not usual want executables to be kept in version control.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub