Re: [reSIProcate] no Contact allowed in MESSAGE

[Scott Godin <sgodin@xxxxxxxxxxxxxxx>]

You are still allowed to send a MESSAGE request within an existing dialog.  Many applications will send a MESSAGE request in a SIP Invite dialog.  This change would break that capability.  For out of dialog MESSAGE requests - the PagerMessage logic doesn't use a Contact header.

Scott

On Thu, Jun 19, 2014 at 1:24 PM, John Gregg <jgregg@xxxxxxxxx> wrote:

As per RFC 3428, section 4:

MESSAGE requests do not initiate dialogs.  User Agents MUST NOT
   insert Contact header fields into MESSAGE requests.

Accordingly, I think the following change should be made to Dialog::makeRequest() (diff from Dialog.cxx, version 1.9.6 attached):

   request.remove(h_Contacts);
   if (method != MESSAGE) // RFC 3428, section 4: no Contact allowed in MESSAGE
   {
request.header(h_Contacts).push_front(mLocalContact);
   }


_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel