[reSIProcate] Question about ClientSubscription and onRequestRetry

[Francis Joanis <francis.joanis@xxxxxxxxx>]

Hi guys,

For the following scenario:

- DUM UAC sends SUBSCRIBE to UAS

- UAS isn't responding and UAC times out

- On the UAC, onRequestRetry gets called and returns 0 (to retry ASAP)

- DUM retries

- UAS replies as usual (normal SIP flow)

In that case, we would expect onNewSubscription(client) to be called when the NOTIFY comes in once the 2nd SUBSCRIBE works but it doesn't...

It looks like the following line (91) in ClientSubscription.cxx:

if(!mOnNewSubscriptionCalled && !getAppDialogSet()->isReUsed())

should actually read

if(!mOnNewSubscriptionCalled && getAppDialogSet()->isReUsed())

without the ! in front of the second check.

I made a quick test and it looks like it resolves the issue, but I wanted to run it by you guys before submitting a fix. What do you think?

Thanks,

Francis