| < Previous by Date | Date Index | Next by Date > |
| Thread Index |
It looks like some of the changes made by the WebRTC patch may be attempted bug fixes and not strictly WebRTC functionality. Even without concluding the WebSockets work, it may be desirable to merge some of these into trunk, or fix the issues more formally somehow, as some of the changes in the patch just suppress issues. I've made a list of things that I notice: http://svn.resiprocate.org/viewsvn/resiprocate/branches/b-webrtc/rutil/dns/RRCache.cxx?r1=9964&r2=9965&diff_format=l (attempt to fix an assert) I actually removed this change in the branch: http://list.resiprocate.org/archive/resiprocate-commit/msg07140.html and my instance of repro is running fine without it, so it is not a strict dependency for WS to work. http://svn.resiprocate.org/viewsvn/resiprocate/branches/b-webrtc/resip/stack/DnsResult.cxx?r1=9964&r2=9965&diff_format=l (hiding an assert) I've also removed that change and my own testing has been done without it: http://list.resiprocate.org/archive/resiprocate-commit/msg07145.html http://svn.resiprocate.org/viewsvn/resiprocate/branches/b-webrtc/resip/stack/Helper.cxx?r1=9964&r2=9965&diff_format=l (hiding an assert) also reverted as part of my own testing: http://list.resiprocate.org/archive/resiprocate-commit/msg07147.html http://svn.resiprocate.org/viewsvn/resiprocate/branches/b-webrtc/resip/stack/MessageFilterRule.cxx?r1=9964&r2=9965&diff_format=l (commented out fix - do we need that code?) http://svn.resiprocate.org/viewsvn/resiprocate/branches/b-webrtc/resip/stack/TransactionState.cxx?r1=9964&r2=9965&diff_format=l (hiding an assert)