RE: [reSIProcate] RE: creating a SipMessage using SipMessage::make, SDP fmtp line appears at the top of the attribute list
I was able to reproduce this and agree that your fix is correct. I've
committed the fix to SVN. Thanks.
> -----Original Message-----
> From: resiprocate-devel-bounces@xxxxxxxxxxxxxxxxxxx
[mailto:resiprocate-
> devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Justin Matthews
> Sent: Tuesday, October 11, 2005 3:56 PM
> To: 'Jason Fischl'
> Cc: resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> Subject: RE: [reSIProcate] RE: creating a SipMessage using
> SipMessage::make,SDP fmtp line appears at the top of the attribute
list
>
> SdpContents.cxx ~1613:
>
> // don't store twice
> mFormats.clear();
> mAttributeHelper.clearAttribute(rtpmap);
>
> Should there also be a:
> mAttributeHelper.clearAttribute(fmtp);
>
> ??
>
> -----Original Message-----
> From: Justin Matthews [mailto:justin.matthews@xxxxxxx]
> Sent: Tuesday, October 11, 2005 3:52 PM
> To: 'Jason Fischl'
> Cc: 'resiprocate-devel@xxxxxxxxxxxxxxxxxxx'
> Subject: RE: [reSIProcate] RE: creating a SipMessage using
> SipMessage::make,
> SDP fmtp line appears at the top of the attribute list
>
> I believe there is an issue here.
>
> After changing my code to the following, INVITE's are sent with double
> fmtp
> entries (although this time they are at the bottom of the list).
Calling
> medium::codecs() forces parsing of the codecs, which will move the
> attributes from the medium into the individual codes. When the sip
> message
> is encoded for transport, the fmtp map will appear at the bottom of
the
> list. Unfortunately now there are two fmtp entries. Is this a bug?
>
>
> My Code:
>
> for (std::list<resip::SdpContents::Session::Medium>::const_iterator i
=
> medias.begin(); i != medias.end(); i++)
> {
> if( i->name() != "audio" )
> {
> continue;
> }
>
> const
std::list<resip::SdpContents::Session::Codec>
> &codecs = i->codecs();
>
>
> }
> //////////////////
> resip::SipMessage &inviteMsg =
> dum_->makeInviteSession(msg->resipMsg_.header(h_To),appDialogSet-
> >userProfil
> e_,sdp,appDialogSet);
>
>
> dum_->send(inviteMsg);
>
>
> Contents sent on the wire:
>
> Content-Length: 225
>
> v=0
> o=TalkingSIPUser 2536331408 2536331408 IN IP4 192.168.2.4
> s=SIP Call
> c=IN IP4 192.168.2.4
> t=0 0
> m=audio 18382 RTP/AVP 0 101
> a=rtpmap:0 PCMU/8000
> a=rtpmap:101 telephone-event/8000
> a=fmtp:101 0-15
> a=fmtp:101 0-15
>
> -----Original Message-----
> From: jason.fischl@xxxxxxxxx [mailto:jason.fischl@xxxxxxxxx] On Behalf
Of
> Jason Fischl
> Sent: Monday, October 10, 2005 1:49 PM
> To: Justin Matthews
> Cc: resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [reSIProcate] RE: creating a SipMessage using
> SipMessage::make,
> SDP fmtp line appears at the top of the attribute list
>
> On 10/10/05, Justin Matthews <justin.matthews@xxxxxxx> wrote:
> > Hi,
> >
> > Could someone please comment on this issue?
>
> This seems like a case where you should probably modify your version
> of SdpContents locally. This doesn't seem like a change that the
> community would want in general. Please correct me if I'm mistaken on
> this.
>
> >
> > Thanks,
> >
> > -Justin
> >
> > -----Original Message-----
> > From: Justin Matthews [mailto:justin.matthews@xxxxxxx]
> > Sent: Tuesday, October 04, 2005 2:49 PM
> > To: 'resiprocate-devel@xxxxxxxxxxxxxxxxxxx'
> > Subject: creating a SipMessage using SipMessage::make, SDP fmtp line
> appears
> > at the top of the attribute list
> >
> > Hello,
> >
> > When creating a SipMessage from a string using SipMessage::make()
that
> > contains SDP:
> >
> > v=0
> > o=MyUser 2403208976 2403208976 IN IP4 192.168.2.4
> > s=SIP Call
> > c=IN IP4 192.168.2.4
> > t=0 0
> > m=audio 18382 RTP/AVP 0 101
> > a=rtpmap:0 PCMU/8000
> > a=rtpmap:101 telephone-event/8000
> > a=fmtp:101 0-15
> >
> > Calling the following:
> >
> > sdp = my_cast_macro(resip::SdpContents*,resipMsg_.getContents());
> > ...
> > resip::SipMessage &inviteMsg =
> >
> dum_->makeInviteSession(msg->resipMsg_.header(h_To),appDialogSet-
> >userProfil
> > e_,sdp,appDialogSet);
> > ...
> > dum->Send(inviteMsg)
> >
> > Results in the following SDP on the wire:
> >
> > v=0
> > o=MyUser 2403208976 2403208976 IN IP4 192.168.2.4
> > s=SIP Call
> > c=IN IP4 192.168.2.4
> > t=0 0
> > m=audio 18382 RTP/AVP 0 101
> > a=fmtp:101 0-15
> > a=rtpmap:0 PCMU/8000
> > a=rtpmap:101 telephone-event/8000
> >
> > The fmtp attribute entry appears at the top of the list. I believe
that
> a
> > vendor is having problems parsing this. Does anyone know how to get
the
> > fmtp attribute to be listed at the bottom of the list?
> >
> > Thanks,
> >
> > -Justin
> >
> > _______________________________________________
> > resiprocate-devel mailing list
> > resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> > https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel
> >
>
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel@xxxxxxxxxxxxxxxxxxx
> https://list.sipfoundry.org/mailman/listinfo/resiprocate-devel