[reSIProcate] War on Warnings, late snow, setting -Werror

[Scott Godin]

Hi Daniel,

Great stuff.

There are still a lot of warnings in the Visual Studio build, mostly in the
64-bit builds with size mismatch warnings - I'm surprised these don't come
up in GCC builds.  Are you building 64-bit?

Example:
3>resip\resip\stack\SdpContents.cxx(1362,16): warning C4267: 'argument':
conversion from 'size_t' to 'resip::Data::size_type', possible loss of data

On another note you have introduced a few new warnings for windows users:
-one was around a missing ; in the {} scoped define resip_assert_not_null
-  I addressed that one, and committed.

(one of these for each instance of pragma GCC):
3>resip\resip\stack\InterruptableStackThread.cxx(28,9): warning C4068:
unknown pragma 'GCC'

I'm guessing these should be wrapped in #ifdefs checking for GCC first.

Regards,
Scott

On Sun, May 16, 2021 at 1:56 PM Daniel Pocock <daniel at pocock.pro> wrote:

>
> This month we have late snow[1], my bike is in the garage and there were
> no more excuses... I eliminated all the compiler warnings in both the
> g++ and Clang builds.  This also included some tweaks for the headers we
> use from sipXtapi.
>
> In this build, there are no more warnings...
>
> https://travis-ci.org/github/resiprocate/resiprocate/builds/771329711
>
>
> Consequently, I set -Werror in CPPFLAGS for the travis-ci builds.  This
> makes the build more strict.
>
> From now on, if anybody makes a commit or pull request including a
> warning, builds in travis-ci will fail as if that was an error.
>
> I've observed some builds failing[2] intermittently with a segmentation
> fault.  This may be an issue in travis-ci.  I'll try to improve the
> travis-ci log configuration to reveal a stack trace.
>
> Regards,
>
> Daniel
>
>
> 1.
>
> https://www.meteosuisse.admin.ch/home/actualite/meteosuisse-blog/meteosuisse-blog.subpage.html/fr/data/blogs/2021/5/une-premiere-quinzaine-de-mai-fraiche.html
> 2. https://travis-ci.org/github/resiprocate/resiprocate/builds/771324663
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel at resiprocate.org
> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20210517/7ed8a670/attachment.htm>