[reSIProcate] repro AssumeFirstHopSupportsOutbound not quite working?

[Daniel Pocock]

On 02/12/16 20:30, Scott Godin wrote:
> Seems to make sense to disable that error if
> AssumeFirstHopSupportOutbound is true.
> 


Looking at the logic in ServerRegistration::tryFlow[1], it does check
AssumeFirstHopSupportOutbound, but only if the UA has sent reg-id and
instance-id, in other words, if it thinks the UA is fully compliant with
outbound RFC 5626

I think a nicer solution may be adding an additional parameter:

AssumeFirstHopSupportsFlowTokens

or perhaps

AssumeFirstHopSupportsFlowTokenHack

Then people will have more fine grained control over the extent to which
they want to deviate from the standard.

If AssumeFirstHopSupportsFlowTokens==true, it will not care about the
presence of reg-id and instance-id

Regards,

Daniel


1.
https://github.com/resiprocate/resiprocate/blob/master/resip/dum/ServerRegistration.cxx#L452