[reSIProcate] Problem while installing resiprocate

[Mateus Bellomo]

Daniel,

Sorry for the delay to made the commit. I'm having a little trouble to do
the pull request.

I have a fork [1] and I pushed the changes there. Then when I click at
'create pull request' it is mixed with an old pull request that I did
(changing the build/debian.sh to check from where it is running). And I'm
not finding any place to separate this 2 things.


[1] https://github.com/MateusBellomo/resiprocate

2016-05-09 19:09 GMT-03:00 Mateus Bellomo <mateusbellomo at gmail.com>:

> Ok...I will do it.
>
> Just one question: in the config.h the USE_SSL is like this:
>
> #define USE_SSL /**/
>
> what does it means the /**/ ?
>
> 2016-05-09 16:01 GMT-03:00 Daniel Pocock <daniel at pocock.pro>:
>
>>
>>
>> On 09/05/16 20:03, Mateus Bellomo wrote:
>> > I think the definition of USE_SSL is in the resiprocate/configure.ac
>> > <http://configure.ac> (or configure.status) but I dont uderstand the
>> > syntax. Do you think the problem is in one of those files?
>> >
>>
>> Thanks for looking into this
>>
>> Scott, did travis-ci send any emails after the commit or is it not
>> sending them again?
>>
>> Notice that
>>
>> - configure.ac lists each of the flags for the configure script.
>>
>> - when you run configure (it is run by build/debian.sh) it puts the
>> defines into config.h
>>
>> Looking at the commit (the SHA-1 hash is exactly what I needed), I see
>> it changes reTurn/TlsConnection.cxx
>>
>> reTurn/TlsConnection.cxx doesn't include config.h - maybe you could try
>> creating a pull request to add config.h to that and any other files?
>> Have a look at the way we include it elsewhere, it is quite important to
>> do it at the top of the file like this:
>>
>> #if defined(HAVE_CONFIG_H)
>> #include "config.h"
>> #endif
>>
>>
>>
>> Regards,
>>
>> Daniel
>> _______________________________________________
>> resiprocate-devel mailing list
>> resiprocate-devel at resiprocate.org
>> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20160509/3752b640/attachment.htm>