[reSIProcate] dpocock-assert branch merged, logging assert() failures

[Dario Bozzali]

Hello Daniel,

I just noticed that in DialogSet.cxx, line 825, there is an issue in log string:

ErrLog(<< "Can�t create a dialog, on a UAS response.");

Should be:

ErrLog(<< "Can't create a dialog, on a UAS response.");

Could you please check and commit the fix into master?

Thank you and best regards,

Dario.



-----Original Message-----
From: resiprocate-devel [mailto:resiprocate-devel-bounces at resiprocate.org] On Behalf Of Daniel Pocock
Sent: venerdì 10 luglio 2015 12.27
To: resiprocate-devel at resiprocate.org
Subject: [reSIProcate] dpocock-assert branch merged, logging assert() failures





A few months ago I created a branch for changing the way assertions work



It has been merged into master and will be part of 1.10.0 and beyond



A quick summary:



- keep using regular assert() in unit tests, e.g. in resip/stack/test/*.cxx



- keep using regular assert() in contrib and other third party code



- otherwise, use resip_assert()



- autotools (Linux) builds: use the configure option



        --enable-assert-syslog



and a copy of every assertion failure will be logged to syslog



- Windows builds: define LOG_EVENT_AND_ASSERT and a copy of every assertion failure is logged in the event viewer



- setting NDEBUG will still have the same effect, the program will proceed after the failure of a resip_assert().  However, if one of the logging options is enabled, the logging will always take place, regardless of whether NDEBUG is set or not



- the logging has a slight performance penalty as every assert expression has to be evaluated even if NDEBUG is set.  So if you don't want the performance penalty, don't enable the logging, everything will work the way it did before



This has already been useful for detecting intermittent problems such as the SSL_ERROR_WANT_WRITE issue:



http://list.resiprocate.org/archive/resiprocate-devel/msg08840.html



_______________________________________________

resiprocate-devel mailing list

resiprocate-devel at resiprocate.org<mailto:resiprocate-devel at resiprocate.org>

https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20150710/902d6d3c/attachment.htm>