[reSIProcate] retransmit patch

[Scott Godin]

Done - with some minor mods.

Thanks,
Scott


On Thu, Jun 5, 2014 at 11:41 AM, palladin <p-aladin at yandex.ru> wrote:

>  On 06/05/2014 06:28 PM, Scott Godin wrote:
>
> Is there a typo in the diff?  Didn't you mean to call
> handler->outboundRetransmit instead of outboundMessage?
>
>  Scott
>
>
>  On Thu, Jun 5, 2014 at 3:52 AM, palladin <p-aladin at yandex.ru> wrote:
>
>> Dear resip devels,
>> Some time before there was a Transport Logging patch.
>> Could you please extend it with a few lines intended to log retransmit
>> messages?
>> For example:
>>
>> diff --git a/resip/stack/Transport.hxx b/resip/stack/Transport.hxx
>> index 7b530cb..3b5c548 100644
>> --- a/resip/stack/Transport.hxx
>> +++ b/resip/stack/Transport.hxx
>> @@ -77,6 +77,7 @@ class Transport : public FdSetIOObserver
>>        public:
>>            virtual ~SipMessageLoggingHandler(){}
>>            virtual void outboundMessage(const Tuple &source, const Tuple
>> &destination, const SipMessage &msg) = 0;
>> +          virtual void outboundRetransmit( const SendData& data ) = 0;
>>            virtual void inboundMessage(const Tuple& source, const Tuple&
>> destination, const SipMessage &msg) = 0;
>>        };
>>
>> diff --git a/resip/stack/TransportSelector.cxx
>> b/resip/stack/TransportSelector.cxx
>> index c57394d..919bbdb 100644
>> --- a/resip/stack/TransportSelector.cxx
>> +++ b/resip/stack/TransportSelector.cxx
>> @@ -1342,6 +1342,13 @@ TransportSelector::retransmit(const SendData& data)
>>     if(transport)
>>     {
>>        // If this is not true, it means the transport has been removed.
>> +      Transport::SipMessageLoggingHandler* handler =
>> transport->getSipMessageLoggingHandler();
>> +
>> +      if(handler)
>> +      {
>> +        handler->outboundMessage(data);
>> +      }
>> +
>> transport->send(std::auto_ptr<SendData>(data.clone()));
>>     }
>>  }
>>
>> Appreciate in advance.
>> tez.
>> _______________________________________________
>> resiprocate-devel mailing list
>> resiprocate-devel at resiprocate.org
>> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>>
>
>  Hi,
> you are quite right, there must be outboundRetransmit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20140606/03653933/attachment.htm>