[reSIProcate] Crash bug in the DnsSub.cxx and AresDns.cxx

[Karlsson]

This is a very great job. Thanks


On Wed, Dec 19, 2012 at 11:18 PM, Scott Godin <sgodin at sipspectrum.com>wrote:

> That would be great thanks Dmytro!  At one time we had an idea to generate
> a pcap file with all messaging, but it never got completed, this sounds
> like a good framework for adding this type of functionality.
>
> Scott
>
>
> On Wed, Dec 19, 2012 at 10:15 AM, Dmytro Bogovych <
> dmytro.bogovych at gmail.com> wrote:
>
>> BTW i have other mod for resiprocate - transport log interface.
>>
>> Interface is here:
>> https://dl.dropbox.com/u/16255670/InternalTransport.hxx
>>
>> Its goal is to notify about incoming&outgoing SIP/STUN traffic.
>> Useful for traffic dump without wireshark.
>>
>> Let me know if you want to apply it to svn - i will send all related
>> source files.
>>
>>
>>
>> On Wed, Dec 19, 2012 at 3:38 PM, Scott Godin <sgodin at sipspectrum.com>
>> wrote:
>> > Thanks again guys - new fix is also committed now.
>> >
>> > Scott
>> >
>> >
>> > On Wed, Dec 19, 2012 at 4:13 AM, Karlsson <boost.regex at gmail.com>
>> wrote:
>> >>
>> >> Thanks for share, yes, I did same patch in the FdPoll.cxx, it's works
>> >> fine, just report it to mailist then Scott can submit it to mainline.
>> >>
>> >> Best regards,
>> >>
>> >>
>> >> On Wed, Dec 19, 2012 at 1:35 PM, Dmytro Bogovych
>> >> <dmytro.bogovych at gmail.com> wrote:
>> >>>
>> >>> It should help:
>> >>> https://dl.dropbox.com/u/16255670/FdPoll.cxx
>> >>>
>> >>>
>> >>> On Wed, Dec 19, 2012 at 5:02 AM, Karlsson <boost.regex at gmail.com>
>> wrote:
>> >>> > I have tested the patch, it still crashed in
>> >>> > FdPollItemBase::~FdPollItemBase()
>> >>> > {
>> >>> >     mPollGrp->delPollItem(mPollHandle);
>> >>> > }
>> >>> >
>> >>> > The mPollGrp is NULL.
>> >>> >
>> >>> >
>> >>> >
>> >>> > On Tue, Dec 18, 2012 at 9:49 PM, Scott Godin <
>> sgodin at sipspectrum.com>
>> >>> > wrote:
>> >>> >>
>> >>> >> Thanks Guys!  I have committed this patch to SVN mainline and will
>> get
>> >>> >> back ported into 1.8.6.
>> >>> >>
>> >>> >> Scott
>> >>> >>
>> >>> >>
>> >>> >> On Tue, Dec 18, 2012 at 4:32 AM, Dmytro Bogovych
>> >>> >> <dmytro.bogovych at gmail.com> wrote:
>> >>> >>>
>> >>> >>> I can confirm this.
>> >>> >>> My workaround:
>> >>> >>> https://dl.dropbox.com/u/16255670/AresDns.cxx
>> >>> >>>
>> >>> >>>
>> >>> >>> On Tue, Dec 18, 2012 at 11:06 AM, Karlsson <boost.regex at gmail.com
>> >
>> >>> >>> wrote:
>> >>> >>> > In the 1.8.5, I got the crashed often, once I debug it, I think
>> >>> >>> > there
>> >>> >>> > is a
>> >>> >>> > bug:
>> >>> >>> >
>> >>> >>> > In the DnsSub.cxx:
>> >>> >>> >
>> >>> >>> > DnsStub::~DnsStub()
>> >>> >>> > {
>> >>> >>> >    for (set<Query*>::iterator it = mQueries.begin(); it !=
>> >>> >>> > mQueries.end();
>> >>> >>> > ++it)
>> >>> >>> >    {
>> >>> >>> >       delete *it;
>> >>> >>> >    }
>> >>> >>> >
>> >>> >>> >    setPollGrp(0);
>> >>> >>> >    delete mDnsProvider;
>> >>> >>> > }
>> >>> >>> >
>> >>> >>> > The parameter of  "setPollGrp" function is 0, so in the
>> >>> >>> > AresDns::setPollGrp(FdPollGrp *grp) function, if the
>> >>> >>> > mPollItems is not empty, will cause
>> AresDnsPollItem::resetPollGrp
>> >>> >>> > crash.
>> >>> >>> >
>> >>> >>> >
>> >>> >>> >
>> >>> >>> >
>> >>> >>> >
>> >>> >>> >
>> >>> >>> >
>> >>> >>> >
>> >>> >>> > _______________________________________________
>> >>> >>> > resiprocate-devel mailing list
>> >>> >>> > resiprocate-devel at resiprocate.org
>> >>> >>> > https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>> >>> >>> _______________________________________________
>> >>> >>> resiprocate-devel mailing list
>> >>> >>> resiprocate-devel at resiprocate.org
>> >>> >>> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>> >>> >>
>> >>> >>
>> >>> >
>> >>
>> >>
>> >
>>
>
>
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel at resiprocate.org
> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20121220/9b95c916/attachment.htm>