[reSIProcate] Major Merge to Resiprocate SVN Trunk

[Scott Godin]

Yes I think Adam's right.  Byron had intended to deprecate those API's, as
all of the fdset processing can be hidden in the FdPollGrp logic now.  I
agree we should be updating StackThread and InterruptableStackThread.  I'll
wait a bit and see if Byron chimes in on this.

Thanks,
Scott

On Wed, Feb 1, 2012 at 1:49 PM, Adam Roach <adam at nostrum.com> wrote:

> On 2/1/12 12:08 PM, Aron Rosenberg wrote:
>
>> This warning appears new with your merge when building on Linux Ubuntu 64
>> bit
>>
>> StackThread.cxx: In member function ‘virtual void
>> resip::StackThread::thread()’:
>> StackThread.cxx:28: warning: ‘virtual void resip::SipStack::buildFdSet(**resip::FdSet&)’
>> is deprecated (declared at ../../resip/stack/SipStack.**hxx:624)
>> StackThread.cxx:36: warning: ‘virtual void resip::SipStack::process(**resip::FdSet&)’
>> is deprecated (declared at ../../resip/stack/SipStack.**hxx:641)
>> InterruptableStackThread.cxx: In member function ‘virtual void resip::**
>> InterruptableStackThread::**thread()’:
>> InterruptableStackThread.cxx:**29: warning: ‘virtual void
>> resip::SipStack::process(**resip::FdSet&)’ is deprecated (declared at
>> ../../resip/stack/SipStack.hxx :641)
>> InterruptableStackThread.cxx:**31: warning: ‘virtual void
>> resip::SipStack::buildFdSet(**resip::FdSet&)’ is deprecated (declared at
>> ../../resip/stack/SipStack. hxx:624)
>> InterruptableStackThread.cxx:**41: warning: ‘virtual void
>> resip::SipStack::process(**resip::FdSet&)’ is deprecated (declared at
>> ../../resip/stack/SipStack.hxx :641)
>>
>>
>>
> This would appear to stem from some cares compatibility changes; from the
> merge notes Scott sent out:
>
>
>  -Some refactoring of the FdPollGrp stuff. Now is compatible with cares,
>> using
>> a bit of a hack. Also compatible with being driven with the old
>> buildFdSet()/
>> select()/process(FdSet&) call sequence, although this is now deprecated.
>> Fixing these compatibility problems allowed us to switch over to using
>> FdPollGrp
>> in all cases, instead of having dual mode everywhere.
>>
>
> It's not clear to me whether we missed some deltas in StackThread and
> InterruptableStackThread -- I would assume they should be updated to use
> the FdPollGrp approach.
>
> /a
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20120201/22ef6db2/attachment.htm>