[reSIProcate] DNS whitelist and testing

[Kennard White]

Hi,

I pulled the changes from CTPC branch for clearing the white list into trunk
(only minor integration issues). I then looked for a unit test to extend to
test this functionality ... and I'm stuck :-).

1. Is there an existing test of whitelist functionality that would be a
natural place to extend to clearing of the whitelist? Does anyone at CTPC
have a unit test for this?

2. stack/testDns.cxx seems pretty complete, but...
2a. It doesn't appear to test whitelisting (as far as I can tell). There is
some commented out code for RRVip but that is it.
2b. I cannot even tell if the test pass in its current form: a lot of white,
green and red text flys by and I don't know if that is good or bad.

3. stack/testDnsCache.cxx seems obsolete: there isn't a build rule for it
(in Makefile or VC). It depends upon rutil/dns/LocalDns.cxx which isn't
built under linux. What is the status of these tests? Can they be removed
from the tree? If we're keeping them, I'd like to remove the ifdef
#USE_LOCAL_DNS in ExternalDnsFactory.cxx and replace it with an appLevel
setExternalCreator() call.

I'd like to commit this change (since our app would benefit from it) but
would prefer to have unit test first.

Thanks,
Kennard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20110131/5207bd9a/attachment.htm>