[reSIProcate] SSL Build Rules

[Adam Roach]

Max Bowsher wrote:
> Absolutely - I'm familiar with the pains that getting system paths in -I
> and -L even for non-cross builds can cause.
>
> However, for the SSL_LOCATION variable, this issue isn't a pressing
> concern, since it's defined to be the location of an OpenSSL *source*
> tree rather than an install location

Actually, that's not quite how it works. Check Makefile.pkg:

  ifneq ($(SSL_LOCATION),)
    OPENSSL_LIBNAME :=
    OPENSSL_LDFLAGS := -ldl
    OPENSSL_INCLUDEDIRS := $(SSL_LOCATION)/include
    OPENSSL_LDLIBS_LAST := $(SSL_LOCATION)/libssl.a
    OPENSSL_LDLIBS_LAST += $(SSL_LOCATION)/libcrypto.a
  endif

At the very least, that OPENSSL_INCLUDEDIRS variable will result in the 
addition of a -I flag to some of the compile phases.

> If the user tries to point to an installation of OpenSSL using it, lots
> of things are going to break in an obvious fashion.
>   

If you're building reflow, this is true (however, this is an error -- 
the current integration of OpenSSL support into the build system for 
reflow support needs some retooling). For all other uses, it works fine 
pointing to a built-in-place source tree, or to an installed version of 
OpenSSL. That's the way it has historically worked, and the way I 
believe it should continue to work.

As I mentioned elsewhere, this should be relatively easy to fix, and I 
intend to do so when I find some time.

/a