[reSIProcate] Assert in DialogSetId, issue with from to tag

[Byron Campen]

	I don't know about that. DialogId, at the very least, uses empty  
when a remote-tag param is not present. I figure we should be  
consistent here if we can. Also, making up a tag will prevent us from  
interoperating with 2543 (not a huge concern for most people, but it  
does matter). Of course, we need to make sure that we never end up  
putting an empty tag param in something we send as a result, but I  
think we're ok on that front (I'll look anyway).

Best regards,
Byron Campen


> Instead of empty, how about "missing-generated-by-resip" or some such.
> david
>
> On 9/26/07, Byron Campen <bcampen at estacado.net> wrote:
>>         I wonder if that would violate the principle of least  
>> surprise for
>> someone trying to debug. It seems that the most intuitive behavior
>> would be to leave it empty. Unless we can think of a specific reason
>> otherwise, I'd just leave it empty.
>>
>> Best regards,
>> Byron Campen
>>
>>> We could also create a random tag in this case which would  
>>> *possibly*
>>> ensure that it was treated as a stray.
>>>
>>> On 9/25/07, Byron Campen <bcampen at estacado.net> wrote:
>>>>         There is indeed an assert for external responses in
>>>> DialogSetId.cxx:
>>>> 20. I think the correct thing to do here is just use an empty tag,
>>>> which should just cause the response to be treated as a stray. (See
>>>> DialogUsageManager::processResponse()). Comments?
>>>>
>>>> Best regards,
>>>> Byron Campen
>>>>
>>>>> Receiving a message off the wire with no from tag should never  
>>>>> cause
>>>>> an assert in dum. However, if the message came from the  
>>>>> application,
>>>>> then an assert might be valid. Perhaps, you could provide some  
>>>>> more
>>>>> context.
>>>>>
>>>>> On 5/31/07, Scott Godin <slgodin at icescape.com> wrote:
>>>>>> Sounds like you either manually build, or received a message with
>>>>>> no tag
>>>>>> in the From header.
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: resiprocate-devel-bounces at list.resiprocate.org
>>>>>>> [mailto:resiprocate-devel-bounces at list.resiprocate.org] On
>>>>>>> Behalf Of
>>>>>>> Mandeep Ahuja
>>>>>>> Sent: Wednesday, May 30, 2007 12:39 PM
>>>>>>> To: resiprocate-devel at list.resiprocate.org
>>>>>>> Subject: [reSIProcate] Assert in DialogSetId, issue with from
>>>>>>> to tag
>>>>>>>
>>>>>>> Hi,
>>>>>>> I really need help on this one.
>>>>>>> My phone would randomly crash with the following assert
>>>>>>> "resip::DialogSetId::DialogSetId(c onst resip::SipMessage &):
>>>>>> Assertion
>>>>>>> `msg.header(h_From).exists(p_tag)' failed" Now I looked at the
>>>>>>> code
>>>>>> and
>>>>>>> there are no comments or no error checking. Can someone tell me
>>>>>>> how do
>>>>>>> i
>>>>>>> get around this situation, or why is this happening, or simply
>>>>>>> what
>>>>>>> should I do to fix it.
>>>>>>> thanks
>>>>>>> I appreciate any help
>>>>>>>
>>>>>>> Mandeep
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> resiprocate-devel mailing list
>>>>>>> resiprocate-devel at list.resiprocate.org
>>>>>>> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>>>>>> _______________________________________________
>>>>>> resiprocate-devel mailing list
>>>>>> resiprocate-devel at list.resiprocate.org
>>>>>> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>>>>>>
>>>>> _______________________________________________
>>>>> resiprocate-devel mailing list
>>>>> resiprocate-devel at list.resiprocate.org
>>>>> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>>>>
>>>>
>>
>> _______________________________________________
>> resiprocate-devel mailing list
>> resiprocate-devel at resiprocate.org
>> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
>>