[reSIProcate] [reSIProcate-commit] resiprocate 7042 nash: DialogUsageManager:

Fri Apr 20 13:13:18 CDT 2007

onAnswer provdes the SIP message that conveyed the SDP in the callback:

      virtual void onAnswer(InviteSessionHandle, const SipMessage& msg,
const SdpContents&, AnswerReason reason)=0;

which can be checked to see if it was a 200 or an ack; in any case, your
application would always know if an invite or an ack is expected as that
depends on the intial invite.  I don't see the befefit of knowing if
something is a re-invite; an application will be aware if an o/a exchange
has occurred, if it cares.

PRACK introfuces many more o/a exhanges, which would require more values for
this enum, and code to provde values for the enum.  It also breaks the DUM
encapsultion, which is trying to hide how o/a exhanges occur.  A mid-dalog
update should not look different than a mid dialog re-invite for most use
cases.

Given your requirements the AnswerReason enum can be removed w/out
compromising your application, and should be removed.

-Derek

On 4/20/07, Nash Tsai <nash.teltel at gmail.com> wrote:
>
> Hi Derek,
>
> This was originally added in the TelTel-client branch, as is the DUM API
> offered couldn't tell the onAnswer triggered is a 200 OK or ACK, and I also
> made the distinction of first INVITE and re-INVITE, I haven't get into the
> details of understanding PRACK, all I know it's a PRE-ACK thing, can you
> explain why it will complicate PRACK development?
>
> Nash
>
>
>
> On 4/20/07, Derek MacDonald <derek at counterpath.com > wrote:
>
> > Hi Nash,
> >
> > What is the motivation for InviteSessionHandler::AnswerReason? This adds
> > complexity and doesn't really fit the DUM api, and will complicate PRACK
> > development, or separating out the offer/answer state machine. I think we
> > should remove this unless there is a compelling use case.
> >
> > -Derek
> >
> >  On 4/9/07, svn at resiprocate.org < svn at resiprocate.org > wrote:
> >
> > >    Project resiprocate New Revision 7042<http://svn.resiprocate.org/viewsvn/resiprocate?view=rev&rev=7042>
> > > Committer nash (Nash Tsai) Date 2007-04-09 02:02:41 -0500 (Mon, 09 Apr
> > > 2007) Log
> > >
> > >  DialogUsageManager:
> > >   add ExternalMessageHandler interface
> > >   add hasEvent method
> > >   changes to process methods to allow mutex lock while in-processing
> > >
> > >  ClientRegistration/ClientSubscription/ClientPagerMessage/ClientPublication/InviteSession/ServerInviteSession/ServerPagerMessage:
> > >
> > >
> > >
> > >   Provide asynchronous method access by using command
> > >
> > >
> > >
> > > Added:
> > >
> > >    - main/resip/dum/ExternalMessageBase.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ExternalMessageBase.hxx?rev=7042>
> > >    - main/resip/dum/ExternalMessageHandler.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ExternalMessageHandler.hxx?rev=7042>
> > >
> > > Modified:
> > >
> > >     - main/resip/dum/ClientInviteSession.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientInviteSession.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientInviteSession.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientInviteSession.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientPagerMessage.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPagerMessage.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientPagerMessage.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPagerMessage.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientPublication.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPublication.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientPublication.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientPublication.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientRegistration.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientRegistration.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientRegistration.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientRegistration.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientSubscription.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientSubscription.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ClientSubscription.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ClientSubscription.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/DialogUsageManager.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DialogUsageManager.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/DialogUsageManager.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DialogUsageManager.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/DumCommand.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/DumCommand.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/InviteSession.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSession.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/InviteSession.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSession.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/InviteSessionHandler.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSessionHandler.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/InviteSessionHandler.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/InviteSessionHandler.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ServerInviteSession.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerInviteSession.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ServerInviteSession.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerInviteSession.hxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ServerPagerMessage.cxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerPagerMessage.cxx?r1=7041&r2=7042&diff_format=l>
> > >    - main/resip/dum/ServerPagerMessage.hxx
> > >    <http://svn.resiprocate.org/viewsvn/resiprocate/main/resip/dum/ServerPagerMessage.hxx?r1=7041&r2=7042&diff_format=l>
> > >
> > >
> > > _______________________________________________
> > > resiprocate-commit mailing list
> > > resiprocate-commit at list.resiprocate.org
> > > https://list.resiprocate.org/mailman/listinfo/resiprocate-commit
> > >
> >
> >
> > _______________________________________________
> > resiprocate-devel mailing list
> > resiprocate-devel at list.resiprocate.org
> > https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20070420/5e207834/attachment.htm>