[reSIProcate] bug in Dialog.cxx?
Byron Campen
bcampen at estacado.net
Tue Jul 25 14:23:58 CDT 2006
I noticed something that looks incorrect in Dialog.cxx around line 600.
*snip*
case REFER:
if(mInviteSession)
{
mInviteSession->mSentRefer = false;
if (code >= 300)
{
mDum.mInviteSessionHandler->onReferRejected
(mInviteSession->getSessionHandle(), msg);
}
else
{
//!dys! the OR condition below is not draft
compliant.
if (!mInviteSession->mReferSub &&
((msg.exists(h_ReferSub) && msg.header
(h_ReferSub).value()=="false") ||
!msg.exists(h_ReferSub)))
{
DebugLog(<< "refer accepted with norefersub");
mDum.mInviteSessionHandler->onReferAccepted
(mInviteSession->getSessionHandle(),
ClientSubscriptionHandle::NotValid(), msg);
}
// else no need for action - first Notify will
cause onReferAccepted to be called
}
break;
}
// fall through, out of dialog refer was sent.
case SUBSCRIBE:
*snip*
Something tells me that we don't really want to fall into case
SUBSCRIBE here if mInviteSession is NULL.
Best regards,
Byron Campen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2369 bytes
Desc: not available
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20060725/7f0b9211/attachment.bin>
More information about the resiprocate-devel
mailing list