[reSIProcate] Re: [reSIProcate-commit] COMMIT: resiprocate 5978sgodin: - fixed nasty cut-and-paste bug in AclStore - db forAcl's now working

[Scott Godin]

Ah right - I see.  I needed access to the TlsPeerName stored in the
TlsConnection object.  What if instead we set the TlsPeerName in a new field
in the message - maybe in the security attributes?  
 
Rohan and I quickly discussed this - and he was concerned about increasing
the size of the SipMessage for people that may not be interested in Peer
Name - but I still think this option is nice and clean and definately more
efficient for repro to lookup.  Is anyone opposed to this?
 
Scott

  _____  

From: resiprocate-devel-bounces at list.sipfoundry.org
[mailto:resiprocate-devel-bounces at list.sipfoundry.org] On Behalf Of Jason
Fischl
Sent: Sunday, February 19, 2006 2:18 PM
To: resiprocate
Subject: [reSIProcate] Re: [reSIProcate-commit] COMMIT: resiprocate
5978sgodin: - fixed nasty cut-and-paste bug in AclStore - db forAcl's now
working


These sorts of accessors are not thread safe if accessed outside of the
transaction layer. In general, the transport layer cannot be directly
accessed outside of the Transaction layer. 

Jason



On 2/17/06, svn at sipfoundry.org <svn at sipfoundry.org> wrote: 

Project	 resiprocate	
New Revision	 5978
<http://scm.sipfoundry.org/viewsvn/resiprocate?view=rev&rev=5978> 	
Committer	 sgodin (Scott Godin)	
Date	 2006-02-17 14:42:43 -0800 (Fri, 17 Feb 2006)	

Log

 - fixed nasty cut-and-paste bug in AclStore - db for Acl's now working
 - changed AclStore peer name matching to non-case sensitive
 - added some const accessors
 


Modified:


*	main/repro/AbstractDb.cxx
<http://scm.sipfoundry.org/viewsvn/resiprocate/main/repro/AbstractDb.cxx?r1=
5977&r2=5978&diff_format=l> 

*	main/repro/AclStore.cxx
<http://scm.sipfoundry.org/viewsvn/resiprocate/main/repro/AclStore.cxx?r1=59
77&r2=5978&diff_format=l> 

*	main/repro/monkeys/IsTrustedNode.cxx
<http://scm.sipfoundry.org/viewsvn/resiprocate/main/repro/monkeys/IsTrustedN
ode.cxx?r1=5977&r2=5978&diff_format=l> 

*	main/resip/stack/ConnectionManager.cxx
<http://scm.sipfoundry.org/viewsvn/resiprocate/main/resip/stack/ConnectionMa
nager.cxx?r1=5977&r2=5978&diff_format=l> 

*	main/resip/stack/ConnectionManager.hxx
<http://scm.sipfoundry.org/viewsvn/resiprocate/main/resip/stack/ConnectionMa
nager.hxx?r1=5977&r2=5978&diff_format=l> 

*	main/resip/stack/TcpBaseTransport.hxx
<http://scm.sipfoundry.org/viewsvn/resiprocate/main/resip/stack/TcpBaseTrans
port.hxx?r1=5977&r2=5978&diff_format=l> 


_______________________________________________
resiprocate-commit mailing list
resiprocate-commit at list.sipfoundry.org
<mailto:resiprocate-commit at list.sipfoundry.org> 
https://list.sipfoundry.org/mailman/listinfo/resiprocate-commit





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://list.resiprocate.org/pipermail/resiprocate-devel/attachments/20060219/286b5aa0/attachment.htm>