Re: [reSIProcate-users] Improvements in SIP Session Timers

[Scott Godin <sgodin@xxxxxxxxxxxxxxx>]

Hi Julio,

1.  After reading RFC4028 - I agree we should only be inserting Min-SE into requests and 422 responses.  I've modified the code in InviteSession::setSessionTimeHeaders method to conditionally set the Min-SE header:

      if(msg.isRequest() || 

         (msg.isResponse() && msg.header(h_StatusLine).responseCode() == 422))

      {

         msg.header(h_MinSE).value() = mMinSE;

      }

Can you please try this out and let me know how it works for you and I can commit it?

2.  I agree that having a configuration MinSE in the profile settings makes sense.  This should be very straight forward to implement.  If you would like to tackle this and submit a GitHub pull request for the changes we can get that into the public version.

Thanks,

Scott Godin

On Thu, Jan 29, 2015 at 7:07 AM, Julio Cesar Esteves Cabezas <jcabezas@xxxxxxxxxxxxx> wrote:

Hi,

     In the past, people in my company had some troubles of interoperation of reSIProcate user-agent with other systems, involving operation of session-timers.

     I don't have details but I am reviewing that feature in reSIProcate, so the questions below:

 

1. Non-compliance

    I observed that when a reSIProcate-based UAS receives an initial INVITE with Session-Expires and Min-SE headers it replies with a 200 OK response that contains both Session-Expires and Min-SE headers.

    That behaviour disagrees with RFC 4028 Sec.5 that says "The Min-SE header field MUST NOT be used in responses except for those with a 422 response code. It indicates the minimum value of the session interval that the server is willing to accept."

    What implications that non-compliance could have in terms of interoperability ?

  

2. Selectable Min-SE

    What is the feasibility of allowing in the DUM the selection of Min-SE the same way that today can be done with default session time ?

    That would allow for easier simulation and tests of interoperability between entities with non-default (90 s) Min-SE requirements.

 

Best regards,

Julio.

 

_______________________________________________
resiprocate-users mailing list
resiprocate-users@xxxxxxxxxxxxxxx
List Archive: http://list.resiprocate.org/archive/resiprocate-users/