< Previous by Date | Date Index | Next by Date > |
< Previous in Thread | Thread Index |
Are there apps that use rutil without using resip/stack? Might it make sense to move the Tuple impl into the rutil version, and then call it from Tuple for backward compat?
KennardOn Sun, Jan 16, 2011 at 9:21 AM, Scott Godin <sgodin@xxxxxxxxxxxxxxx> wrote:
Yup - found those as well. The implementation in Tuple is better, it does a case insensitive compare, and it is more efficient. I plan to mark the TransportType implementation as Deprecated.Thanks,ScottOn Sun, Jan 16, 2011 at 12:08 PM, Kennard White <kennard_white@xxxxxxxxxxxx> wrote:
Hi Scott,
I looked into this briefly before when I was having an interop issue, and found that there was redundant functionality between rutil/TransportType.cxx and resip/stack/Tuple.cxx (e.g., see toTransport()). They have different implementations, and I wasn't sure which one was better. Would be good to consolidate.
I agree that it would better to send lower case.
KennardOn Sun, Jan 16, 2011 at 7:32 AM, Scott Godin <sgodin@xxxxxxxxxxxxxxx> wrote:
In general URI parameters are not case sensitive. There is text on page 155 of RFC3261 that illustrates this:The URIs within each of the following sets are equivalent:sip:%61lice@xxxxxxxxxxx;transport=TCP
sip:alice@xxxxxxxxxxx;Transport=tcpThe base grammar however shows the transport parameter in lowercase, so using a lowercase transport parameter is likely to give you a higher level of interoperability with endpoints that ignore the fact that uri parameters are not case sensitive.
I think it is a good idea to change resip to use lowercase transport types in the transport URI parameter - any objections to this? Also I found a couple of cases in resip where we don't properly to a case insensitive parse of the transport parameter and we are looking for upper case only - I'll fix these.ScottOn Fri, Jan 14, 2011 at 7:59 PM, Karlsson <boost.regex@xxxxxxxxx> wrote:
_______________________________________________Hi, I noticed that the "TCP" is upper-case in the "Contact" header once TCP transport using, in RFC standard does it case-sensitive ?
REGISTER sip:sip.example.com SIP/2.0
Via: SIP/2.0/TCP 192.168.1.168:7545;branch=z9hG4bK-d8754z-882a07326842fc18-1---d8754z-;rport
Max-Forwards: 70
Contact: <sip:137244491822@xxxxxxxxxxxxx:7545;rinstance=405113f40e6faed4;transport=TCP>
resiprocate-users mailing list
resiprocate-users@xxxxxxxxxxxxxxx
List Archive: http://list.resiprocate.org/archive/resiprocate-users/
_______________________________________________
resiprocate-users mailing list
resiprocate-users@xxxxxxxxxxxxxxx
List Archive: http://list.resiprocate.org/archive/resiprocate-users/