< Previous by Date Date Index Next by Date >
  Thread Index Next in Thread >

[reSIProcate-users] Changed interface to ClientSubscriptionHandler?


Hello,

It appears that the interface to 2 pure virtual callback functions in the 
ClientSubscriptionHandler have changed, causing our source code to break 
slightly from reSIProcate 1.4.1 to 1.5:
> diff -bu resiprocate-1.4.1/resip/dum/SubscriptionHandler.hxx 
> resiprocate-1.5/resip/dum
--- resiprocate-1.4.1/resip/dum/SubscriptionHandler.hxx 2009-04-16 
18:32:57.000000000 +0200
+++ resiprocate-1.5/resip/dum/SubscriptionHandler.hxx   2009-05-08 
17:51:41.000000000 +0200
@@ -24,12 +24,13 @@
       virtual int onRequestRetry(ClientSubscriptionHandle, int retrySeconds, 
const SipMessage& notify)=0;

       //subscription can be ended through a notify or a failure response.
-      virtual void onTerminated(ClientSubscriptionHandle, const SipMessage& 
msg)=0;
+      virtual void onTerminated(ClientSubscriptionHandle, const SipMessage* 
msg)=0;
       //not sure if this has any value.
       virtual void onNewSubscription(ClientSubscriptionHandle, const 
SipMessage& notify)=0;

       /// called to allow app to adorn a message.
       virtual void onReadyToSend(ClientSubscriptionHandle, SipMessage& msg);
+      virtual void onNotifyNotReceived(ClientSubscriptionHandle);
 };

 class ServerSubscriptionHandler

Was this really necessary? Can we consider changing these back?

Thanks,
Chris

This e-mail and any attachment is for authorised use by the intended 
recipient(s) only. It may contain proprietary material, confidential 
information and/or be subject to legal privilege. It should not be copied, 
disclosed to, retained or used by, any other party. If you are not an intended 
recipient then please promptly delete this e-mail and any attachment and all 
copies and inform the sender. Thank you.