Re: [reSIProcate] [resiprocate] Innocent change of a helper (#25)

[Dario Bozzali <notifications@xxxxxxxxxx>]

In ServerAuthManager::handleUserAuthInfo() method it is used static Helper::advancedAuthenticateRequest() that doesn't have the issue since it uses Helper::makeResponseMD5WithA1() with the proper number of arguments.
In this way the change is innocent (and maybe the fixed mistake).
You could face the issue if you use Helper::authenticateRequest() to check authentication and you want to use qop, since in that case (before the patch) you use Helper::makeResponseMD5() actually without taking into account message contents...
@TafThorne Nice comment :)

—
Reply to this email directly or view it on GitHub.