Re: [reSIProcate] [reTurn-devel] STUN over TCP

[Scott Godin <sgodin@xxxxxxxxxxxxxxx>]

Hi John,

Thanks for the contribution.

Note: reTurn already supports STUN/TURN over TCP/UDP/TLS.  The ConnectionBase class applies to the resiprocate stack only, so these changes don't really benefit reTurn in anyway.

As for the resip stack changes.  RFC5626 doesn't recommend the use of STUN use over TCP for SIP socket keepalives.  See the following text from RFC5626:

 For connection-oriented
   transports such as TCP [RFC0793] and SCTP [RFC4960], this
   specification describes a keep-alive approach based on sending CRLFs.
   For connectionless transport, such as UDP [RFC0768], this
   specification describes using STUN [RFC5389] over the same flow as
   the SIP traffic to perform the keep-alive.

What is your use case for requiring STUN handling on a TCP based SIP transport?

Regards,

Scott

On Tue, May 20, 2014 at 10:52 AM, John Gregg <jgregg@xxxxxxxxx> wrote:

My company has modified 1.9.6 to do STUN over TCP. I am cross-posting this to return-devel and resiprocate-devel because the two files we changed are in resip/stack, but I figure changes involving STUN might interest the reTurn folks as well. We enclosed our changes in the conditional compilatoin flag AYLUS_CHANGE_STUN_OVER_TCP, which should be removed if/when this code is ever incorporated into the codebase. Also, because we only act as a STUN server, we #if 0'ed the code that processes STUN responses. No guarantees about the disabled code. Diff files attached (ConnectionBase.cxx and ConnectionBase.hxx changes from 1.9.6).

-John Gregg


_______________________________________________
reTurn-devel mailing list
reTurn-devel@xxxxxxxxxxxxxxx
List Archive: http://resiprocate.org/archive/return-devel/