Re: [reSIProcate] Allow-Events header field

[Ionut Slaveanu <islaveanu@xxxxxxxxx>]

Currently, resiprocate doesn't add "Allow-Events" header field in a 489 (Bad Event) response, although RFC 3265 and RFC 3903 says that this field is mandatory.

I have a patch for this problem.

In function DialogUsageManager::checkEventPackage(const SipMessage& request)

Currently, is:
   if (failureCode > 0)
   {
      SharedPtr<SipMessage> response(new SipMessage);
      makeResponse(*response, request, failureCode);
      send(response);
      return false;
   }

It should be added the following line after makeResponse function:
      response->header(h_AllowEvents) = getMasterProfile()->getAllowedEvents();

Could someone check if this fix is correct and commit that.

Thank you!

On Tue, Mar 4, 2014 at 5:40 PM, Adam Roach <adam@xxxxxxxxxxx> wrote:

On 3/4/14 15:10, Dragos Dinu wrote:

As I am working with an RLS implementation using resiprocate and while making sure we follow the SUBSCRIBE/NOTIFY rfc, I stumbled upon this particular issue:

From RFC 3265: 

   Any node implementing one or more event packages SHOULD include an 
   appropriate "Allow-Events" header indicating all supported events in 
   all methods which initiate dialogs and their responses (such as 
   INVITE) and OPTIONS responses. 

This would mean that the responses for a SUBSCRIBE should contain the Allow-Events header field. However, I noticed that resiprocate uses this only with invite session handlers and out of dialog handlers. Should resiprocate also use this header field with server subscription handlers?

Yes.

/a

_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel