Re: [reSIProcate] Patch for rutil
On 25/09/13 04:41, Karlsson wrote:
> I watch a bug/defect in the rutil/stun, with currently code, the
> recvfrom function which in the udp.cxx will be block then cause the
> application freeze if the stun server IP/domain is not live(not
> respond). I have created a patch which is set the socket timeout to
> 600 ms, and it will try three times if failed, just for reference.
>
Hi Karlsson,
Did you find any test case which tests this class or do you think it
would be very difficult to create such a test case that simulates the
bug (e.g. by referring to an IP that is deliberately blackholed)
On a more general note, some test cases like that would potentially need
a local environment configured to simulate certain problems and may not
be valid in CI (on travis-ci.org). We could use some environment
variable to specify whether such test cases run or not.
Regards,
Daniel