Re: [reSIProcate] Stale Call Timer

[Scott Godin <sgodin@xxxxxxxxxxxxxxx>]

Thanks Jason.  I have removed the randomization part from SVN trunk.

Scott

On Tue, Sep 24, 2013 at 1:56 PM, Jason Fischl <jason.fischl@xxxxxxxxx> wrote:

I cannot for the life of me remember why this was added. It makes no sense to me. The commit comment is a mystical, "fix issue with onStaleCallTimeout" and might as well be, "fixed for windows". 

It may be worth taking this randomization out and seeing if people squawk about something. 

Jason

On Tue, Sep 24, 2013 at 6:35 AM, Scott Godin <sgodin@xxxxxxxxxxxxxxx> wrote:

Hi Thom,

I've often wondered the same thing.  I'd be game for removing it.  It was added by Jason/CounterPath back in 2005.  Jason do you have any recollection of this?  : )

Scott

On Tue, Sep 24, 2013 at 6:06 AM, Thomas Troy <thomas.troy@xxxxxxxxxxxxxxxxxxxx> wrote:

Hi,

 

I was recently looking at controlling how to take down a call that hasn’t been answered within a reasonable time frame. One of the ways to do this is the StaleCallTimer which calls onStaleCallTimeout in the InviteSessionHandler.

 

However, this cannot be relied upon to give a consistent user experience because resiprocate takes the user profile setting and adds a random number of seconds (up to 120) when starting the timer. I’m just wondering what is the reasoning for this?

 

 

void

ClientInviteSession::startStaleCallTimer()

{

   InfoLog (<< toData(mState) << ": startStaleCallTimer");

   unsigned long when = mDialog.mDialogSet.getUserProfile()->getDefaultStaleCallTime();

   when += Random::getRandom() % 120;

 

   mDum.addTimer(DumTimeout::StaleCall,

                 when,

                 getBaseHandle(),

                 ++mStaleCallTimerSeq);

}

 

Regards,

Thom

Accuris Networks is a Private Limited Company registered in the Republic of Ireland.
Registered Number is 265266, with a registered office at O'Connell Bridge House, D'Olier St, Dublin 2.

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel