Re: [reSIProcate] Request for symbols definition (WS and WSS)

[Daniel Pocock <daniel@xxxxxxxxxxxxx>]

On 16/09/13 18:56, Dario Bozzali wrote:
> Hi all,
> 
> It would be possible to add to mainline the definitions for symbols WS
> and WSS (see below)?
> 


I remember looking at that code when doing the WebRTC work but deciding
not to include WS and WSS in Symbols.?xx - I think the reason I didn't
include them is because I couldn't find other code explicitly referring
to these strings and it seemed better for people to use rutil/TransportType

Can anybody else comment on these definitions?  Should they be supported
or are they deprecated?


>  
> 
> Symbols.hxx:
> 
> static const char* WS;
> 
> static const char* WSS;
> 
>  
> 
> Symbols.cxx:
> 
> const char* Symbols::WS = "WS";
> 
> const char* Symbols::WSS = "WSS";
> 
>  
> 
> Moreover, in my opinion in method TransportType::isSecure() WS and WSS
> transports should be handled (see below).
> 



It looks like something went wrong with those changes when the b-webrtc
branch was merged.

10079 fixes isSecure, I have cherry-picked it from b-webrtc into main

SVN believed the change was already merged, I had to force it to cherry
pick this with --ignore-ancestry

svn merge --ignore-ancestry -c 10079
https://svn.resiprocate.org/rep/resiprocate/branches/b-webrtc .

Thanks for the feedback about these issues

Regards,

Daniel