| < Previous by Date | Date Index | Next by Date > |
| < Previous in Thread | Thread Index | Next in Thread > |
Generally, we use the resip-defined UInt32, but something that we may want to start thinking about is to move over to using the now standard integer types defined in c++-11. Not sure how far back support for these goes; we may need to supply typedefs for them in some cases, but we should start building the good habit now.
Best regards,
Byron Campen
This appears to be a general issue for 64 bit builds using IPv6
It is due to the use of unsigned long* in Tuple::isEqualWithMask(...)
Only 4 bytes are wanted but unsigned long is 8 bytes on s390x
I've replaced it with UInt32* (from compat.hxx) and that makes the test
run succcessfully (r10296) but I'd appreciate it if somebody could
clarify a couple of things:
a) should I use UInt32, uint32_t or some other type - is there any
preference in reSIProcate?
b) what is the likely impact - was this code just there for
isPrivateAddress() or is it relied on more extensively by anybody?
repro/AclStore appears to use it
On 18/07/13 22:30, Daniel Pocock wrote:
> The s390 build is OK now but on s390x there is something odd with testTuple
>
>
> https://buildd.debian.org/status/fetch.php?pkg=resiprocate&arch=s390x&ver=1.8.11-3&stamp=1374177130
>
>
> lt-testTuple: testTuple.cxx:40: int main(): Assertion
> `testTuple1.isPrivateAddress()' failed.
> /bin/bash: line 5: 22350 Aborted ${dir}$tst
> FAIL: testTuple
>
> Tuple testTuple1("fd9b:70f6:0a18:31cc::1", 5069, V6, TCP);
> assert(testTuple1.isPrivateAddress());
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel@xxxxxxxxxxxxxxx
> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel
_______________________________________________
resiprocate-devel mailing list
resiprocate-devel@xxxxxxxxxxxxxxx
https://list.resiprocate.org/mailman/listinfo/resiprocate-devel