Re: [reSIProcate] [resip/stack][patch] Fixes for previous patch (titled: Code cleanup for ConnectionBase.cxx)

[Daniel Pocock <daniel@xxxxxxxxxxxxx>]

On 19/05/13 14:11, Zhi An Ng wrote:
> Hi all,
>
> The patch I submitted had some problems, sorry about that. Here are 2
> commits to fix the issues brought up by Daniel (thanks!).
>
> First commit has to do with a missing return value in:
> `ConnectionBase::scanMsgHeader(int bytesRead)`
>
> Second patch is regarding the returned value of
> `makeWsHandshakeResponse()`, it now returns a std::auto_ptr<Data> to
> reduce memory usage. The check for the return value of this function
> is also fixed changed to
> `if (wsResponsePtr.get())`
>
> These changes are also reflected in the pull request on GitHub.


I reviewed the pull request and manually merged into SVN
https://github.com/resiprocate/resiprocate/pull/2

See commits 1022[123]:

http://list.resiprocate.org/archive/resiprocate-commit/

Notice that I had to make one fix, when you create an auto_ptr, please
give it a pointer to an object created by the `new' operator.

Thanks for your contribution to the reSIProcate project.

Regards,

Daniel