[reSIProcate] Question about handling NOTIFY responses for ServerSubscriptions

[Francis Joanis <francis.joanis@xxxxxxxxx>]

Hi guys,

We need to add a callback like ServerSubscriptionHandler::onNotifyAccepted (similar to onNotifyRejected) but I stumbled over the following in Dialog.cxx:

At line 804 (in Dialog::dispatch) we see that all incoming errors for NOTIFY messages are sent to all subscriptions. Do you think this is correct (also see comment at line 795 which pretty much asks the same question)?

I'm asking because we would need to add another if statement so that 200-class responses are sent to the ServerSubscription to call the new onNotifyAccepted handler. I'm a little cautious about blindly sending all 200-class messages to all subscription members of mServerSubscriptions... I'd rather use Dialog::findMatchingServerSub to find the proper one.

Also, what would be a case for having multiple server subscriptions in the same Dialog? Maybe the only case where there could be multiple server subscriptions in the same dialog would be if an InviteSession would process multiple REFERs (w/ sub) at the same time... For an actual UAS SUBSCRIBE dialog I wonder if that would even be possible.

Thanks a lot,

Francis