< Previous by Date Date Index Next by Date >
< Previous in Thread Thread Index  

Re: [reSIProcate] status of nrappkit, nICEr, p2p and s2c code?


Copying Eric who is one of the authors.

Jason


On Sat, Jan 7, 2012 at 2:42 AM, Daniel Pocock <daniel@xxxxxxxxxxxxx> wrote:
>
>
>
> I've been looking at the nICEr, p2p and s2c code
>
> They all seem to depend on the third party code nrappkit:
> https://sourceforge.net/projects/nrappkit
>
> which has only had one release in 2006
>
> a) is nrappkit still supported in any sense?  should it potentially be
> forked (copied into the resiprocate repo)?
>
> b) nrappkit's pre.mk file statically defines sizes for various types,
> e.g. -DSIZEOF_LONG=4 does not seem ideal for x86_64 compilation -
> changing this value to 8 causes a lot of other warnings and errors though
>
> c) the s2c code includes part of the make system from nrappkit, but it
> doesn't appear to be a complete make system for building the s2c module
> - it seems that there is another Makefile that bypasses the s2c build system
>
> d) the p2p module appears to depend on the s2c module, so I'm not sure
> if it's possible to build p2p for all platforms without:
> - understanding how to build s2c
> - ensuring that nrappkit is good for the target platform
>
> e) nICEr also appears to be based on the nrappkit build system, it
> appears more complete than for s2c, but it needed some extra stuff in
> pre.mk:
>
> GLOBAL_CFLAGS += -I$(NRAPPKIT_SRCDIR)/src/share
> GLOBAL_CFLAGS += -I$(NRAPPKIT_SRCDIR)/src/registry
> GLOBAL_CFLAGS += -I$(NRAPPKIT_SRCDIR)/src/stats
>
> f) nICEr also has issues on 64 bit compile, similar to nrappkit:
>
> nICEr/src/make/debian/../../ice/ice_component.c: In function
> ‘nr_ice_component_nominated_pair’:
> nICEr/src/make/debian/../../ice/ice_component.c:622: error: cast from
> pointer to integer of different size
> nICEr/src/make/debian/../../ice/ice_component.c:627: error: cast from
> pointer to integer of different size
> nICEr/src/make/debian/../../ice/ice_component.c:633: error: cast from
> pointer to integer of different size
> make: *** [ice_component.o] Error 1
>
> (if I ignore those by temporarily removing -Werror, it builds without
> any other real errors)
>
> g) the nICEr README suggests that nrappkit needs to be unpacked in
> resip/nICEr (I just did a symlink).  I found that it actually needed two
> symlinks:
>
> resip/nrappkit -> ~/src/nrappkit
> resip/nICEr/nrappkit -> ~/src/nrappkit
>
>
> _______________________________________________
> resiprocate-devel mailing list
> resiprocate-devel@xxxxxxxxxxxxxxx
> https://list.resiprocate.org/mailman/listinfo/resiprocate-devel