< Previous by Date Date Index Next by Date >
  Thread Index Next in Thread >

[reSIProcate] rutil/DataBuffer.cxx: likely signed-ness problem


Hi,

Static code analysis indicates a likely problem in rutil/DataBuffer.cxx:

int
DataBuffer::overflow(int c)
{
   // sync, but reallocate
   size_t len = pptr() - pbase();
   if (len >= 0)
   {


Since size_t is unsigned, the if statement is always true. My guess is that the original author wanted len to be a signed type. But I have no idea what this function does. Anyone?

Kennard