Re: [reSIProcate] [Patch] Add support for AfterSocketCreationFuncPtr when using c-ares
Hi,
Just curious now that c-ares 1.7.1 supports ipv6 name servers if there is
any plan to add this feature when using c-ares with resip. Also, what is
the general state of c-ares support in resip?
Thanks,
-justin
-----Original Message-----
From: resiprocate-devel-bounces@xxxxxxxxxxxxxxx
[mailto:resiprocate-devel-bounces@xxxxxxxxxxxxxxx] On Behalf Of Brad Spencer
Sent: Tuesday, December 16, 2008 6:16 PM
To: Gregor Jasny
Cc: resiprocate-devel@xxxxxxxxxxxxxxx
Subject: Re: [reSIProcate] [Patch] Add support for
AfterSocketCreationFuncPtr when using c-ares
On Sat, Dec 13, 2008 at 11:21:43PM +0100, Gregor Jasny wrote:
> On Sat, Dec 13, 2008 at 02:30:17PM -0400, Brad Spencer wrote:
> > Now that c-ares 1.6.0 supports socket creation callback functions, I
> > have added support for the AfterSocketCreationFuncPtr resiprocate
> > callback when using c-ares.
> >
> > In detail:
> >
> > - Implemented AfterSocketCreationFuncPtr when using c-ares (requires
> > 1.6.0)
>
> Can we check for the 1.6.0 during configure?
We probably should, I suppose. I imagine by the time the next resiprocate
release is made from the trunk, you'll have your IPv6 patch in c-ares. I
think it's fair to consider that to be the bare minimum for really being
able to use the two libraries together in the general case, so requiring
whatever version of c-ares that turns out to be (1.7.0?) is probably the
right thing to do.
I will take a look at doing this over the next couple of days. I guess the
best strategy is to grep the ares_version.h header?
> > - Added TODOs for supporting IPv6 DNS server addresses with c-ares
> > (coming soon)
>
> The c-ares patch will take some extra days. I still don't find the
> time to look at the segfault issue.
I'm in no hurry, but let me know if I can help. I've been planning to write
the resiprocate patch to support the IPv6 DNS server addresses once your
stuff is in c-ares, but if you'd prefer to do it, just let me know.
> I had the nearly same patch im my patch queue. Should have sent it
> earlier.
Likewise, if yours is better, I will take no offense if you post it instead
;)
--
----------------------------------------------------------
Brad Spencer - spencer@xxxxxxxxxxxxx - www.starscale.com