Re: [reSIProcate] Gearing up for 1.6 release

[Byron Campen <bcampen@xxxxxxxxxxxx>]

        I assume the assert() should go too then.

Best regards,
Byron Campen

> Hi Byron,
>
> Byron Campen wrote:
> >    I have started work on getting a 1.6 release candidate ready for  
> > the
> > upcoming SIPit.
>
> I've noticed a bug in the rutil DNS stuff that should get fixed  
> before 1.6:
>
> If in DnsStub::cacheTTL the soa vector is empty after createOverlay  
> because of just unsupported types, the function should return.
>
> Best regards,
> Gregor
> Index: rutil/dns/DnsStub.cxx
> ===================================================================
> --- rutil/dns/DnsStub.cxx       (revision 8543)
> +++ rutil/dns/DnsStub.cxx       (working copy)
> @@ -218,6 +218,7 @@
>    vector<RROverlay> soa;
>    aptr = createOverlay(abuf, alen, aptr, soa);
>    assert (!soa.empty());
> +   if (soa.empty() return;
>
>    RRCache::instance()->cacheTTL(key, rrType, status, soa[0]);
> }

Attachment: smime.p7s
Description: S/MIME cryptographic signature