< Previous by Date Date Index Next by Date >
  Thread Index Next in Thread >

[reSIProcate] CSeq is incorrect in NOTIFY generated by DUM on SUBSCRIBE


Hi All,

As I see dum is incorrectly generates CSeq in NOTIFY in case when SUBSCRIBE's 
SCeq was not 1. NOTIFY's CSeq always starts from 2 in spite of CSeq in 
SUBSCRIBE was not 1.
 
The fast patch is very simple:

--- resip/dum/Dialog.cxx
+++ resip/dum/Dialog.cxx
@@ -136,7 +136,7 @@
       }

       mRemoteCSeq = request.header(h_CSeq).sequence();
-      mLocalCSeq = 1;
+      mLocalCSeq = request.header(h_CSeq).sequence();

       DebugLog ( << "************** Created Dialog as UAS **************" );
       DebugLog ( << "mRemoteNameAddr: " << mRemoteNameAddr );

Also, after code review I've found that mRemoteCSeq is never used and looks 
like it could be safety removed.

Regards,
Volodymyr!